cpu - remove vectorize warnings for Clang -O3#1831
Merged
Conversation
jedbrown
reviewed
May 30, 2025
jedbrown
left a comment
jedbrown
left a comment
Member
There was a problem hiding this comment.
I don't anticipate any impact on performance from removing the pragma in these positions.
jeremylt
force-pushed
the
jeremy/vectorize-warnings
branch
from
May 30, 2025 20:52
b596856 to
b79896b
Compare
Member
Author
|
Testing BP4 on a 20x20x20 box mesh with order 3 elements in Ratel, `OPT="-O2 -march=native"
And BP4 with a 30x30x30 box mesh
but without the second commit, BP4 with a 20x20x20 box mesh
And BP4 with a 30x30x30 box mesh
So I'm dropping the second commit and merging |
jeremylt
force-pushed
the
jeremy/vectorize-warnings
branch
from
June 3, 2025 16:27
b79896b to
4baa7ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't think this has any performance issues, but in this branch I've tried to silence Clang's vectorization warnings at -O3 by only marking the innermost restriction loops with CeedPragmaSIMD. Given the difficulty of actually vectorizing nested loops unless the inner loop range is fixed, I'd guess this has no effect on our actual performance?