Skip to content

ex - use deal.II fe to build libCEED Basis#1827

Merged
jeremylt merged 4 commits into
mainfrom
jeremy/dealII-basis
Jun 2, 2025
Merged

ex - use deal.II fe to build libCEED Basis#1827
jeremylt merged 4 commits into
mainfrom
jeremy/dealII-basis

Conversation

@jeremylt

Copy link
Copy Markdown
Member

@peterrum I don't know if this is how to best approach this, but have tried to use the deal.II fe object to build the libCEED Basis object. (I apologize for my non-ideomatic C++). Is this a reasonable approach?

@jeremylt
jeremylt requested a review from peterrum May 27, 2025 16:55
@jeremylt jeremylt self-assigned this May 27, 2025

@peterrum peterrum left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeremylt Thank you for working for this! The 1D information you need is inside of https://www.dealii.org/developer/doxygen/deal.II/structinternal_1_1MatrixFreeFunctions_1_1ShapeInfo.html => https://www.dealii.org/developer/doxygen/deal.II/structinternal_1_1MatrixFreeFunctions_1_1UnivariateShapeData.html (shape_values, shape_gradients, quadrature). Do you want to give it a try else I would do it tomorrow or on Thursday! One question: who is responsible for cleaning up after new?

@jeremylt

Copy link
Copy Markdown
Member Author

Thanks for that info - I can give it a try.

Re new, that was my oops. The data is copied in the libCEED Basis constructor, so I should have deleteed those arrays.

@jeremylt
jeremylt force-pushed the jeremy/dealII-basis branch from 2a5c0a4 to 571e8cf Compare May 27, 2025 19:07

@peterrum peterrum left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment thread examples/deal.II/bps.h Outdated
Comment on lines +212 to +213
for (const auto q : quadrature.get_tensor_basis()[0].get_points())
q_ref_1d.push_back(q(0));

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread examples/deal.II/bps.h Outdated
Comment thread examples/deal.II/bps.h Outdated
@jeremylt
jeremylt force-pushed the jeremy/dealII-basis branch from 134d7d7 to c311271 Compare June 2, 2025 16:07
Co-authored-by: Peter Munch <peterrmuench@gmail.com>
@jeremylt
jeremylt force-pushed the jeremy/dealII-basis branch from c311271 to bec2b28 Compare June 2, 2025 16:25
@jeremylt
jeremylt merged commit 6108493 into main Jun 2, 2025
@jeremylt
jeremylt deleted the jeremy/dealII-basis branch June 2, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants