rust - update rust examples to match c/python#1826
Merged
Conversation
jedbrown
approved these changes
May 19, 2025
jedbrown
left a comment
jedbrown
left a comment
Member
There was a problem hiding this comment.
LGTM. There's perhaps excess duplication here. We could consolidate to one crate with multiple binaries (so they can all share the lib part) or split out a utility crate that all the binaries would use.
Member
Author
|
Yeah, at some point it would be nice to tidy that up more. I have mixed feelings sometimes about how much code to collapse together as these are sorta intended as tutorial examples? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the naming convention to match C/Python better and added ex3