Merged
Conversation
runer112
reviewed
Mar 8, 2026
Member
runer112
left a comment
There was a problem hiding this comment.
Could you use the call _ \ .db string, 0 \ _ trick to eliminate rload and ld_relative entirely?
Contributor
Author
|
|
Member
Oh, duh. EDIT: Also it wouldn't even be helpful in this case because you want the string pointer in a register here, not on the stack. Don't know what I was thinking. |
runer112
approved these changes
Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that
rload/ld_relativeare only used with a positive offset less than 256, so I was able to save space by storing the offset in 1 byte instead of 3 bytes.I also changed the following error messages:
ERROR: Missing Library-->ERROR: Library MissingERROR: Invalid Library-->ERROR: Library InvalidThis was done so all three error strings start with the same prefix of
ERROR: Library.