Skip to content

Expose expected minimum in result response#26

Merged
langdal merged 4 commits into
mainfrom
feature/add-expected_minimum-to-response
Sep 23, 2021
Merged

Expose expected minimum in result response#26
langdal merged 4 commits into
mainfrom
feature/add-expected_minimum-to-response

Conversation

@langdal

@langdal langdal commented Sep 22, 2021

Copy link
Copy Markdown
Member

Add expected minimum to the result.

Closes #10

@langdal langdal self-assigned this Sep 22, 2021
@langdal langdal marked this pull request as ready for review September 22, 2021 08:29
@langdal langdal requested a review from sqbl September 22, 2021 08:29

@sqbl sqbl left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Looks good to me. This is a killer feature to add!
As I understand, specifications.yml states that expected_minimum is returned as a list of lists. It is good if we keep it this way.
Today the simple call of expected_minimum (as outlined in optimizer.py) will return a list comprising the recipe for the expected_min (as a list) and a guestimate of the value (as a number).
In a near future, we can add a flag to the call of expected_min that will also return the standard deviation in the guestimated value. This standard deviation will be returned as part of a list together with the value.
As in:

expected_minimum(result, return_std=True)
>>> ([x[0],...,x[n]], [y-value, y-std])

I believe that the presented implementation (in the API back-end) will already allow such data structure from the call(?).

Best,
Søren

@langdal

langdal commented Sep 23, 2021

Copy link
Copy Markdown
Member Author

Correct, the data structure will be able to support standard deviation (and additional values) in the current specification.

@langdal langdal merged commit 1bfb36d into main Sep 23, 2021
@langdal langdal deleted the feature/add-expected_minimum-to-response branch September 23, 2021 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add expected minimum to response

2 participants