This repository was archived by the owner on Mar 25, 2025. It is now read-only.
Added error handling for values not in scope#502
Merged
Conversation
Collaborator
|
Can one of the admins verify this patch? |
iomaganaris
approved these changes
Jan 25, 2021
Contributor
iomaganaris
left a comment
iomaganaris
left a comment
There was a problem hiding this comment.
LGTM. Good addition 👍
georgemitenkov
force-pushed
the
georgemitenkov/symtable-error-handling
branch
from
587abfb to
77fe958
Compare
georgemitenkov
force-pushed
the
georgemitenkov/symtable-error-handling
branch
from
77fe958 to
6251a3f
Compare
pramodk
approved these changes
Jan 25, 2021
pramodk
pushed a commit
that referenced
this pull request
Feb 23, 2021
Added error handling when a non-scope value is looked up. Before, such a lookup would yield a nullptr, therefore leading to a segmentation fault. This PR adds a lookup function that wraps around value symbol lookup, and throws an error with a message if nullptr is returned.
pramodk
pushed a commit
that referenced
this pull request
May 8, 2021
Added error handling when a non-scope value is looked up. Before, such a lookup would yield a nullptr, therefore leading to a segmentation fault. This PR adds a lookup function that wraps around value symbol lookup, and throws an error with a message if nullptr is returned.
pramodk
pushed a commit
that referenced
this pull request
Mar 8, 2022
Added error handling when a non-scope value is looked up. Before, such a lookup would yield a nullptr, therefore leading to a segmentation fault. This PR adds a lookup function that wraps around value symbol lookup, and throws an error with a message if nullptr is returned.
iomaganaris
pushed a commit
that referenced
this pull request
May 10, 2022
Added error handling when a non-scope value is looked up. Before, such a lookup would yield a nullptr, therefore leading to a segmentation fault. This PR adds a lookup function that wraps around value symbol lookup, and throws an error with a message if nullptr is returned.
iomaganaris
pushed a commit
that referenced
this pull request
May 12, 2022
Added error handling when a non-scope value is looked up. Before, such a lookup would yield a nullptr, therefore leading to a segmentation fault. This PR adds a lookup function that wraps around value symbol lookup, and throws an error with a message if nullptr is returned.
iomaganaris
pushed a commit
that referenced
this pull request
Sep 15, 2022
Added error handling when a non-scope value is looked up. Before, such a lookup would yield a nullptr, therefore leading to a segmentation fault. This PR adds a lookup function that wraps around value symbol lookup, and throws an error with a message if nullptr is returned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small PR to add error handling when a non-scope value is looked up. Before, such a lookup would yield a
nullptr, therefore leading to a segfault. This PR adds alookupfunction that wraps around symbol lookup, and throws an error with a message ifnullptris returned.