Function call support

[georgemitenkov]

This patch introduces support for function call code generation, particularly:

• User-defined procedures and functions are supported
• Framework for external method has been created, currently support for exp and pow has been added

Added corresponding tests.

fixes #472

[bbpbuildbot]

Can one of the admins verify this patch?

[pramodk]

nice! LGTM!

About Jenkins CI failure:

default — Build finished.

I am taking a look at this on internal CI node. There is some weird linker issue with Intel compiler. I will try to fix this by tomorrow otherwise we can merge this.

[pramodk]

If that was not the case, cast instructions had to be created.

this won't be required, at DSL level we will make sure to have correct types.

[pramodk]

About Jenkins CI failure:
default — Build finished.
I am taking a look at this on internal CI node. There is some weird linker issue with Intel compiler. I will try to fix this by tomorrow otherwise we can merge this.

@georgemitenkov : to fix Jenkins build issue, you have to do small change:

$ git diff
diff --git a/test/unit/CMakeLists.txt b/test/unit/CMakeLists.txt
index d4b29bf..f0c2e95 100644
--- a/test/unit/CMakeLists.txt
+++ b/test/unit/CMakeLists.txt
@@ -98,6 +98,7 @@ if(NMODL_ENABLE_LLVM)
   add_executable(testllvm visitor/main.cpp codegen/llvm.cpp)
   target_link_libraries(
     testllvm
+    llvm_codegen
     codegen
     visitor
     symtab
@@ -105,7 +106,6 @@ if(NMODL_ENABLE_LLVM)
     util
     test_util
     printer
-    llvm_codegen
     ${NMODL_WRAPPER_LIBS}
     ${LLVM_LIBS_TO_LINK})
   set(CODEGEN_TEST testllvm)

The reason for this is that llvm_codegen library has dependency with codegen library (for CodegenHelperVisitor) and hence that needs to be linked after llvm_codegen (as we are building all static libraries). This error appears with Intel compiler (only) that we use under Jernkins CI.

By the way, I assume I mentioned previously how to check Jenkins CI logs. If not, here is summary :

• Click on the Details link

• Login via Gasper account

• It will take you to Jenkins build. Click on the default link:

• And then Console Output on left side bar

• And if you scroll to the end of log, you should see the error:

[pramodk]

CI now looks green!