Use SQLWCHAR array for wide string literals in test suite#161
Merged
justing-bq merged 2 commits intoapache-odbcfrom Mar 19, 2026
Merged
Use SQLWCHAR array for wide string literals in test suite#161justing-bq merged 2 commits intoapache-odbcfrom
justing-bq merged 2 commits intoapache-odbcfrom
Conversation
alinaliBQ
reviewed
Mar 17, 2026
alinaliBQ
approved these changes
Mar 18, 2026
alinaliBQ
left a comment
alinaliBQ
left a comment
There was a problem hiding this comment.
Overall change LGTM, below CI failure is not caused by code changes in this PR.
Error: Unexpected shared dependency found in /Users/runner/work/arrow/arrow/build/cpp/debug/libarrow_flight_sql_odbc.dylib: `libunwind`
Error: Process completed with exit code 1.
|
@justing-bq Can you update the PR description before merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
We want to use a SQLWCHAR array for wide string literal inside our test suite instead of a SQLWCHAR vector.
What changes are included in this PR?
SQLWCHAR vector used for wide string literals are replaced with a SQLWCHAR array instead.
Columns tests were refactored to perform assertions over std::string equality rather than wide string equality.
Are these changes tested?
Yes
Are there any user-facing changes?
No