Removed explicit dependency from litehtml in header#2
Merged
BigJk merged 2 commits intoBigJk:mainfrom Mar 6, 2026
Merged
Conversation
added 2 commits
February 21, 2026 22:45
Owner
|
Makes sense. Thanks! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Including litehtml requires explicit linking with the same library for downstream projects, even if they don't really need visibility or access to the rendering engine itself, and that is nowhere used in the public interface since all registration calls are wrapped already.
This was just solved by moving the CustomElement class specific to the cpp file.
Still, this PR includes #1 as it was not easy to decouple these changes from it, so you might want to consider that first.