Skip to content

Move to core injection#299

Merged
zerebos merged 7 commits intodevelopmentfrom
core-injection
Dec 13, 2022
Merged

Move to core injection#299
zerebos merged 7 commits intodevelopmentfrom
core-injection

Conversation

@zerebos
Copy link
Copy Markdown
Member

@zerebos zerebos commented Dec 11, 2022

After speaking with Strencher, rather than dealing with the vulnerability of renaming the ASAR and potentially corrupting Discord installs, we decided to move all platforms to discord_desktop_core style injection.

@zerebos zerebos requested a review from tropicaaal December 11, 2022 03:01
Copy link
Copy Markdown
Member

@tropicaaal tropicaaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

Comment thread src/renderer/actions/install.js Outdated
Comment thread src/renderer/actions/paths.js Outdated
@zerebos zerebos merged commit fa58466 into development Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants