Workaround another gfortran bug in test_description_t constructors, and expand testing#129
Merged
Merged
Conversation
Before this commit, gfortran 13..14.2 was invoking the wrong constructor overload when passed a diagnosis_function_i pointer as an actual argument. Re-ordering the function declarations in the generic interface appears to be an effective workaround.
Ensure that all the cases are covered and checked for equivalence
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to a previously unknown (to us) defect in gfortran, PR #127 introduced a regression for client code passing a
procedure(diagnosis_function_i) pointerto thetest_description_tconstructor (i.e. using the old!HAVE_PROCEDURE_ACTUAL_FOR_POINTER_DUMMYworkaround).This PR deploys a workaround for that new defect, and expands testing of
test_description_tconstructors to ensure all the cases are covered and continue to work.