Skip to content

Add CONTRIBUTING.md first draft#274

Merged
ktras merged 9 commits into
BerkeleyLab:mainfrom
ktras:add-contributing-doc
Aug 29, 2025
Merged

Add CONTRIBUTING.md first draft#274
ktras merged 9 commits into
BerkeleyLab:mainfrom
ktras:add-contributing-doc

Conversation

@ktras

@ktras ktras commented Aug 29, 2025

Copy link
Copy Markdown
Collaborator

No description provided.

@bonachea bonachea left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many changes requested

Comment thread CONTRIBUTING.MD
Comment thread CONTRIBUTING.MD Outdated
Comment thread CONTRIBUTING.MD Outdated
Comment thread CONTRIBUTING.MD Outdated
Comment thread CONTRIBUTING.MD Outdated
Comment thread CONTRIBUTING.MD Outdated
Comment thread CONTRIBUTING.MD Outdated
@bonachea bonachea linked an issue Aug 29, 2025 that may be closed by this pull request
@ktras ktras requested a review from bonachea August 29, 2025 21:40
Comment thread CONTRIBUTING.md

@bonachea bonachea left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made one additional suggestion, otherwise LGTM

ktras and others added 9 commits August 29, 2025 17:51
@bonachea bonachea force-pushed the add-contributing-doc branch from 8de3644 to 439af53 Compare August 29, 2025 21:51

@rouson rouson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread CONTRIBUTING.MD
Comment thread CONTRIBUTING.MD Outdated
Comment thread CONTRIBUTING.MD Outdated
Comment thread CONTRIBUTING.MD
Comment thread CONTRIBUTING.md
@ktras ktras merged commit 1ae88f1 into BerkeleyLab:main Aug 29, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[JOSS review]: Community guidelines

3 participants