Skip to content

Fix GELU & sigmoid activation precision #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rouson merged 2 commits into from
Oct 10, 2024
Merged

Fix GELU & sigmoid activation precision #214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a06c4d
fix(sigmoid): make real literals double precision
rouson Oct 10, 2024
08f4254
fix(gelu): make constants double-precision
rouson Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/inference_engine/gelu_s.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@
real, parameter :: half = 0.5, two = 2.D0
real, parameter :: sqrt_2_pi = sqrt(2*pi), sqrt_2 = sqrt(2.)

real, parameter :: pi_dp = 3.141592653589793D0
real, parameter :: half_dp = 0.5D0, two_dp = 2.D0
real, parameter :: sqrt_2_pi_dp = sqrt(two_dp*pi_dp), sqrt_2_dp = sqrt(2.D0)
double precision, parameter :: pi_dp = 3.141592653589793D0
double precision, parameter :: half_dp = 0.5D0, two_dp = 2.D0
double precision, parameter :: sqrt_2_pi_dp = sqrt(two_dp*pi_dp), sqrt_2_dp = sqrt(2.D0)

contains

Expand Down
4 changes: 2 additions & 2 deletions src/inference_engine/sigmoid_s.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,15 @@
end procedure

module procedure double_precision_activation
y = 1./(1.+exp(-x))
y = 1.D0/(1.D0+exp(-x))
end procedure

module procedure default_real_activation_derivative
y = exp(-x)/(1.+exp(-x))**2
end procedure

module procedure double_precision_activation_derivative
y = exp(-x)/(1.+exp(-x))**2
y = exp(-x)/(1.D0+exp(-x))**2
end procedure

module procedure function_name
Expand Down