Replace gfortran in CI with flang-new#200
Merged
Merged
Conversation
ktras
changed the title
gfortran in CI with flang-newyaml file that builds with Flang
ktras
force-pushed
the
support-flang-ci
branch
from
fcd5eea to
71860db
Compare
rouson
requested changes
Sep 3, 2024
rouson
left a comment
rouson
left a comment
Contributor
There was a problem hiding this comment.
I suggested one minor change. Otherwise, LGTM.
Co-authored-by: Damian Rouson <rouson@lbl.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docker image being built by developers at NASA that contains LLVM Flang is for Linux architecture, so this PR not only replaces gfortran with flang-new, but also removes the MacOS CI test.
This PR adds
gmao/llvm-flang:latestfor the docker image, but based on a conversation with the creator of the docker image, it might be updated with different configurations in the future, so in the event that thelatestdoesn't work in the future, the tag that is associated with the docker image version that works for this repo isgmao/llvm-flang:2024-08-29.