Create numerics_t type#153
Closed
ktras wants to merge 2 commits into
Closed
Conversation
on the parts of `inference_engine_t` that are needed for inference
Contributor
|
@ktras please ignore this comment. This is a demonstration. |
Contributor
|
@ktras I'm forgetting the motivation for this PR. If you still want to merge it, we can discuss it the next time we talk and then I can review it. |
Contributor
|
@ktras this has suffered some bit rot due to name changes in the relevant code. I suspect this might not be needed anymore so I'm closing it. If you think it's still useful, feel free to make analogous changes on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create-numerics-type on the parts of
inference_engine_tthat are needed for inference