Skip to content

Ensure correct escaping of avatar URL, update tests#2

Open
david-bezero wants to merge 1 commit into
masterfrom
avatar-escaping
Open

Ensure correct escaping of avatar URL, update tests#2
david-bezero wants to merge 1 commit into
masterfrom
avatar-escaping

Conversation

@david-bezero
Copy link
Copy Markdown

Bring in improvements from go-pkgz#184

notably:

  • avatar URLs are now correctly escaped if the user ID contains special characters such as &
  • tests have been updated
  • email fields are no-longer double-encoded

@david-bezero david-bezero requested a review from alek-sys October 30, 2023 12:11
@david-bezero david-bezero mentioned this pull request Oct 30, 2023
@david-bezero
Copy link
Copy Markdown
Author

looks like the upstream PR might get merged at some point, so I'll hold off on merging these changes in favour of another upstream merge a bit later (we don't currently use these features anyway)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants