Skip to content

Comments

portfolio-trading-accounts upsert#584

Open
apawan wants to merge 5 commits intomasterfrom
investment-service/phase-2-data-models-ingestion-trading-account
Open

portfolio-trading-accounts upsert#584
apawan wants to merge 5 commits intomasterfrom
investment-service/phase-2-data-models-ingestion-trading-account

Conversation

@apawan
Copy link
Contributor

@apawan apawan commented Feb 20, 2026

Description

Investment:

  • Implement Portfolio Trading Account Creation

Checklist

  • I made sure, I read CONTRIBUTING.md to put right branch prefix as per my need.
  • I made sure to update CHANGELOG.md.
  • I made sure to update Stream Wiki(only valid in case of new stream module or architecture changes).
  • My changes are adequately tested.
  • I made sure all the SonarCloud Quality Gate are passed.

@apawan apawan requested a review from a team as a code owner February 20, 2026 07:07
Copy link
Collaborator

@Aboruhen Aboruhen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aboruhen Aboruhen changed the base branch from investment-service/phase-2-data-models-ingestion to master February 24, 2026 10:20
Copy link
Collaborator

@Aboruhen Aboruhen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update based on the latest version

@apawan apawan closed this Feb 24, 2026
@apawan apawan reopened this Feb 24, 2026
@apawan apawan force-pushed the investment-service/phase-2-data-models-ingestion-trading-account branch from a7c4648 to aedb524 Compare February 24, 2026 13:23
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
74.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants