Drop support for Ruby 2.3 and 2.4#184
Closed
tancnle wants to merge 1 commit into
Closed
Conversation
tancnle
marked this pull request as ready for review
January 26, 2021 10:20
tancnle
force-pushed
the
drop-support-ruby-2-4
branch
from
January 26, 2021 10:22
0113844 to
30af44e
Compare
tancnle
force-pushed
the
drop-support-ruby-2-4
branch
2 times, most recently
from
January 7, 2022 04:10
656599d to
e2f0fde
Compare
With Ruby 2.3 and 2.4 being EOL, we should move our support accordingly to keep pace with maintenance effort. This also allows simpler interoperability with dependent gems (i.e. `nokogiri`).
tancnle
force-pushed
the
drop-support-ruby-2-4
branch
from
January 7, 2022 04:11
e2f0fde to
b7e70c9
Compare
Author
|
👋🏼 @katmsft Any thoughts on what's left to be done in this PR 🙏🏼 ? |
Author
|
👋🏼 @seanmcc-msft could you kindly help to review this PR, please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With Ruby 2.3 and 2.4 being EOL, we should move our support accordingly to keep pace with maitaintenance effort. This also allows simpler interoperability with dependent gems (i.e.
nokogiri).