feat(dps-device): Add synchronous overloads for registerDevice#1700
Merged
Conversation
A lot of our samples and tests are simplified with this and a lot of customers would probably benefit the same way.
timtay-microsoft
requested review from
abhipsaMisra,
andyk-ms,
brycewang-microsoft,
drwill-ms,
patilsnr and
tmahmood-microsoft
as code owners
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
patilsnr
approved these changes
Apr 11, 2023
Contributor
patilsnr
left a comment
patilsnr
left a comment
There was a problem hiding this comment.
Looks like this really cleans up some of the samples. I'd wait for at least one more approval before merging, if you can.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A lot of our samples and tests are simplified with this and a lot of customers would probably benefit the same way.