feat: Support grounding without parent_ids#27
Open
nicoloesch wants to merge 2 commits into
Open
Conversation
parent_idsparent_ids
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Grounding currently requires one or more explicit
parent_idsto anchor candidates within a known hierarchy. That precision has a cost: it makes grounding unusable in contexts where no such anchor exists yetThis PR adds a parent-less mode: candidates still resolve and standardize to their canonical OMOP form via lexical/semantic search and identity hops, just without ancestor verification. This trades disambiguation power for coverage where no anchor is available.
Implementation
find_standard_pathsnow acceptstargets: Optional[Tuple[int, ...]]separation= ancestor-hierarchy distance to the required parent).IDENTITYin grounding) is accepted directlyseparationrepurposed as the identity-hop distance from the original candidatemax_depthhops to bound the walkStandardConcept.identity_hops: the raw BFS hop count, captured unconditionally in both modes fromitem.iterations(previously computed and discarded). Currently unused but allows disambiguation in the constrained casescoring.py) needed no changes:parsimony_penalty = alpha * separationalready generalisation correctly sinceseparationcarries the right distance for either mode.