Skip to content

#1850 disable internal metric service, add micrometer, add PrometheusMetricsPlugin#1851

Merged
mergify[bot] merged 1 commit into
mainfrom
feature/1850-metrics-on-micrometer
Dec 19, 2024
Merged

#1850 disable internal metric service, add micrometer, add PrometheusMetricsPlugin#1851
mergify[bot] merged 1 commit into
mainfrom
feature/1850-metrics-on-micrometer

Conversation

@robfrank

@robfrank robfrank commented Dec 5, 2024

Copy link
Copy Markdown
Collaborator

What does this PR do?

Implementation of #1850

Related issues

#1850

Checklist

  • I have run the build using mvn clean package command
  • My unit tests cover both failure and success scenarios

@codacy-production

codacy-production Bot commented Dec 5, 2024

Copy link
Copy Markdown

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.24% 78.67%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (9e44506) 68274 43828 64.19%
Head commit (d3328e2) 68297 (+23) 43676 (-152) 63.95% (-0.24%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1851) 75 59 78.67%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@robfrank

robfrank commented Dec 5, 2024

Copy link
Copy Markdown
Collaborator Author

To test the prometheus endpoint, build the binaries

mvn clean install -DskipTests

run the server:

./package/target/arcadedb-25.1.1-SNAPSHOT.dir/arcadedb-25.1.1-SNAPSHOT/bin/server.sh \
-Darcadedb.serverMetrics=true \
-Darcadedb.serverMetrics.logging=true \ 
-Darcadedb.server.plugins=Prometheus:com.arcadedb.metrics.prometheus.PrometheusMetricsPlugin \
-Darcadedb.serverMetrics.prometheus.requireAuthentication=false \
-Darcadedb.server.defaultDatabases="Beer[root]{import:https://github.com/ArcadeData/arcadedb-datasets/raw/main/orientdb/OpenBeer.gz}"

open the browser to http://localhost:2480/prometheus

properties:

  • arcadedb.serverMetrics (deafault to true): enable/disable the metrics
  • arcadedb.serverMetrics.logging (default to false): enable to print out of metring in the logs
  • arcadedb.serverMetrics.prometheus.requireAuthentication (default to true): configure authentication for the endpoint

@gramian

gramian commented Dec 5, 2024

Copy link
Copy Markdown
Collaborator

I can try to add this new functionality to the docs once it is merged.

@robfrank robfrank force-pushed the feature/1850-metrics-on-micrometer branch 7 times, most recently from 7fe6a0f to d978a7a Compare December 13, 2024 14:55
@robfrank robfrank marked this pull request as ready for review December 13, 2024 15:56
…MetricsPlugin, test for PrometheusMetricsPlugin, add configuration param to enable/disable auth
@robfrank robfrank force-pushed the feature/1850-metrics-on-micrometer branch from d978a7a to d3328e2 Compare December 19, 2024 08:13
@robfrank robfrank requested a review from lvca December 19, 2024 08:20
@lvca lvca added this to the 24.12.1 milestone Dec 19, 2024
@mergify mergify Bot merged commit 84b7708 into main Dec 19, 2024
@lvca lvca added the enhancement New feature or request label Dec 19, 2024
@lvca lvca modified the milestones: 24.12.1, 25.1.1 Dec 19, 2024
@robfrank robfrank deleted the feature/1850-metrics-on-micrometer branch June 20, 2025 07:40
mergify Bot added a commit that referenced this pull request May 3, 2026
Bumps `jline.version` from 4.0.12 to 4.0.14.
Updates `org.jline:jline-terminal` from 4.0.12 to 4.0.14
Release notes

*Sourced from [org.jline:jline-terminal's releases](https://github.com/jline/jline3/releases).*

> JLine 4.0.14
> ------------
>
> * fix: correct inverted bounds check in readBuffered methods (3.x backport) ([#1855](https://redirect.github.com/jline/jline3/pull/1855)) [`@​gnodet`](https://github.com/gnodet)
>
> 📦 Dependency updates
> --------------------
>
> * chore: Bump junit.version from 5.14.3 to 5.14.4 ([#1848](https://redirect.github.com/jline/jline3/pull/1848)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * chore: Bump actions/checkout from 4 to 6 ([#1847](https://redirect.github.com/jline/jline3/pull/1847)) @[dependabot[bot]](https://github.com/apps/dependabot)
>
> JLine 4.0.13 is a patch release with bug fixes for terminal handling, GraalVM native-image support, and encoding issues.
>
> Bug Fixes
> ---------
>
> * Fix AttributedStyle color chaining ([#1792](https://redirect.github.com/jline/jline3/issues/1792))
> * Erase probe emoji after grapheme cluster width detection ([#1801](https://redirect.github.com/jline/jline3/issues/1801))
> * Register all FFM foreign function signatures for GraalVM native-image ([#1802](https://redirect.github.com/jline/jline3/issues/1802))
> * Register Kernel32 FFM downcall signatures for GraalVM native-image ([#1803](https://redirect.github.com/jline/jline3/issues/1803))
> * Deprecate SwingTerminal.dispose() in favor of close() ([#1811](https://redirect.github.com/jline/jline3/issues/1811))
> * Avoid NPE when closing terminal with null masterOutput ([#1813](https://redirect.github.com/jline/jline3/issues/1813))
> * Close PTY streams before shutdown to prevent hang on macOS ([#1817](https://redirect.github.com/jline/jline3/issues/1817))
> * Resolve redirect targets against session working directory ([#1781](https://redirect.github.com/jline/jline3/issues/1781))
> * Use terminal encoding instead of default charset in VirtualTerminal ([#1822](https://redirect.github.com/jline/jline3/issues/1822))


Commits

* [`329f24c`](jline/jline3@329f24c) fix: remove proactive isNativeAccessEnabled() checks from terminal providers ...
* [`5e62717`](jline/jline3@5e62717) fix: prevent DA response bytes from leaking to parent shell ([#1856](https://redirect.github.com/jline/jline3/issues/1856))
* [`2700ff2`](jline/jline3@2700ff2) chore: Bump org.graalvm.buildtools:native-maven-plugin ([#1851](https://redirect.github.com/jline/jline3/issues/1851))
* [`b37b1fa`](jline/jline3@b37b1fa) chore: Bump actions/upload-pages-artifact from 4 to 5 ([#1850](https://redirect.github.com/jline/jline3/issues/1850))
* [`3befc1b`](jline/jline3@3befc1b) chore: Bump org.graalvm.sdk:graal-sdk from 25.0.2 to 25.0.3 ([#1852](https://redirect.github.com/jline/jline3/issues/1852))
* [`edc3637`](jline/jline3@edc3637) fix: correct inverted bounds check in readBuffered methods ([#1854](https://redirect.github.com/jline/jline3/issues/1854))
* [`befdfce`](jline/jline3@befdfce) fix: pass explicit version to nisse in release workflow
* [`2571aec`](jline/jline3@2571aec) chore: update nisse extension to 0.8.4
* [`acc413c`](jline/jline3@acc413c) fix: use terminal encoding instead of default charset in VirtualTerminal (fix...
* [`96d9900`](jline/jline3@96d9900) fix: resolve redirect targets against session working directory ([#1781](https://redirect.github.com/jline/jline3/issues/1781))
* Additional commits viewable in [compare view](jline/jline3@4.0.12...4.0.14)
  
Updates `org.jline:jline-reader` from 4.0.12 to 4.0.14
Release notes

*Sourced from [org.jline:jline-reader's releases](https://github.com/jline/jline3/releases).*

> JLine 4.0.14
> ------------
>
> * fix: correct inverted bounds check in readBuffered methods (3.x backport) ([#1855](https://redirect.github.com/jline/jline3/pull/1855)) [`@​gnodet`](https://github.com/gnodet)
>
> 📦 Dependency updates
> --------------------
>
> * chore: Bump junit.version from 5.14.3 to 5.14.4 ([#1848](https://redirect.github.com/jline/jline3/pull/1848)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * chore: Bump actions/checkout from 4 to 6 ([#1847](https://redirect.github.com/jline/jline3/pull/1847)) @[dependabot[bot]](https://github.com/apps/dependabot)
>
> JLine 4.0.13 is a patch release with bug fixes for terminal handling, GraalVM native-image support, and encoding issues.
>
> Bug Fixes
> ---------
>
> * Fix AttributedStyle color chaining ([#1792](https://redirect.github.com/jline/jline3/issues/1792))
> * Erase probe emoji after grapheme cluster width detection ([#1801](https://redirect.github.com/jline/jline3/issues/1801))
> * Register all FFM foreign function signatures for GraalVM native-image ([#1802](https://redirect.github.com/jline/jline3/issues/1802))
> * Register Kernel32 FFM downcall signatures for GraalVM native-image ([#1803](https://redirect.github.com/jline/jline3/issues/1803))
> * Deprecate SwingTerminal.dispose() in favor of close() ([#1811](https://redirect.github.com/jline/jline3/issues/1811))
> * Avoid NPE when closing terminal with null masterOutput ([#1813](https://redirect.github.com/jline/jline3/issues/1813))
> * Close PTY streams before shutdown to prevent hang on macOS ([#1817](https://redirect.github.com/jline/jline3/issues/1817))
> * Resolve redirect targets against session working directory ([#1781](https://redirect.github.com/jline/jline3/issues/1781))
> * Use terminal encoding instead of default charset in VirtualTerminal ([#1822](https://redirect.github.com/jline/jline3/issues/1822))


Commits

* [`329f24c`](jline/jline3@329f24c) fix: remove proactive isNativeAccessEnabled() checks from terminal providers ...
* [`5e62717`](jline/jline3@5e62717) fix: prevent DA response bytes from leaking to parent shell ([#1856](https://redirect.github.com/jline/jline3/issues/1856))
* [`2700ff2`](jline/jline3@2700ff2) chore: Bump org.graalvm.buildtools:native-maven-plugin ([#1851](https://redirect.github.com/jline/jline3/issues/1851))
* [`b37b1fa`](jline/jline3@b37b1fa) chore: Bump actions/upload-pages-artifact from 4 to 5 ([#1850](https://redirect.github.com/jline/jline3/issues/1850))
* [`3befc1b`](jline/jline3@3befc1b) chore: Bump org.graalvm.sdk:graal-sdk from 25.0.2 to 25.0.3 ([#1852](https://redirect.github.com/jline/jline3/issues/1852))
* [`edc3637`](jline/jline3@edc3637) fix: correct inverted bounds check in readBuffered methods ([#1854](https://redirect.github.com/jline/jline3/issues/1854))
* [`befdfce`](jline/jline3@befdfce) fix: pass explicit version to nisse in release workflow
* [`2571aec`](jline/jline3@2571aec) chore: update nisse extension to 0.8.4
* [`acc413c`](jline/jline3@acc413c) fix: use terminal encoding instead of default charset in VirtualTerminal (fix...
* [`96d9900`](jline/jline3@96d9900) fix: resolve redirect targets against session working directory ([#1781](https://redirect.github.com/jline/jline3/issues/1781))
* Additional commits viewable in [compare view](jline/jline3@4.0.12...4.0.14)
  
Updates `org.jline:jline-terminal-jni` from 4.0.12 to 4.0.14
Release notes

*Sourced from [org.jline:jline-terminal-jni's releases](https://github.com/jline/jline3/releases).*

> JLine 4.0.14
> ------------
>
> * fix: correct inverted bounds check in readBuffered methods (3.x backport) ([#1855](https://redirect.github.com/jline/jline3/pull/1855)) [`@​gnodet`](https://github.com/gnodet)
>
> 📦 Dependency updates
> --------------------
>
> * chore: Bump junit.version from 5.14.3 to 5.14.4 ([#1848](https://redirect.github.com/jline/jline3/pull/1848)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * chore: Bump actions/checkout from 4 to 6 ([#1847](https://redirect.github.com/jline/jline3/pull/1847)) @[dependabot[bot]](https://github.com/apps/dependabot)
>
> JLine 4.0.13 is a patch release with bug fixes for terminal handling, GraalVM native-image support, and encoding issues.
>
> Bug Fixes
> ---------
>
> * Fix AttributedStyle color chaining ([#1792](https://redirect.github.com/jline/jline3/issues/1792))
> * Erase probe emoji after grapheme cluster width detection ([#1801](https://redirect.github.com/jline/jline3/issues/1801))
> * Register all FFM foreign function signatures for GraalVM native-image ([#1802](https://redirect.github.com/jline/jline3/issues/1802))
> * Register Kernel32 FFM downcall signatures for GraalVM native-image ([#1803](https://redirect.github.com/jline/jline3/issues/1803))
> * Deprecate SwingTerminal.dispose() in favor of close() ([#1811](https://redirect.github.com/jline/jline3/issues/1811))
> * Avoid NPE when closing terminal with null masterOutput ([#1813](https://redirect.github.com/jline/jline3/issues/1813))
> * Close PTY streams before shutdown to prevent hang on macOS ([#1817](https://redirect.github.com/jline/jline3/issues/1817))
> * Resolve redirect targets against session working directory ([#1781](https://redirect.github.com/jline/jline3/issues/1781))
> * Use terminal encoding instead of default charset in VirtualTerminal ([#1822](https://redirect.github.com/jline/jline3/issues/1822))


Commits

* [`329f24c`](jline/jline3@329f24c) fix: remove proactive isNativeAccessEnabled() checks from terminal providers ...
* [`5e62717`](jline/jline3@5e62717) fix: prevent DA response bytes from leaking to parent shell ([#1856](https://redirect.github.com/jline/jline3/issues/1856))
* [`2700ff2`](jline/jline3@2700ff2) chore: Bump org.graalvm.buildtools:native-maven-plugin ([#1851](https://redirect.github.com/jline/jline3/issues/1851))
* [`b37b1fa`](jline/jline3@b37b1fa) chore: Bump actions/upload-pages-artifact from 4 to 5 ([#1850](https://redirect.github.com/jline/jline3/issues/1850))
* [`3befc1b`](jline/jline3@3befc1b) chore: Bump org.graalvm.sdk:graal-sdk from 25.0.2 to 25.0.3 ([#1852](https://redirect.github.com/jline/jline3/issues/1852))
* [`edc3637`](jline/jline3@edc3637) fix: correct inverted bounds check in readBuffered methods ([#1854](https://redirect.github.com/jline/jline3/issues/1854))
* [`befdfce`](jline/jline3@befdfce) fix: pass explicit version to nisse in release workflow
* [`2571aec`](jline/jline3@2571aec) chore: update nisse extension to 0.8.4
* [`acc413c`](jline/jline3@acc413c) fix: use terminal encoding instead of default charset in VirtualTerminal (fix...
* [`96d9900`](jline/jline3@96d9900) fix: resolve redirect targets against session working directory ([#1781](https://redirect.github.com/jline/jline3/issues/1781))
* Additional commits viewable in [compare view](jline/jline3@4.0.12...4.0.14)
  
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
Dependabot commands and options
  
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot show  ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants