Add tests for CLEAR COLUMN IN PARTITION in SummingMergeTree#128
Open
CarlosFelipeOR wants to merge 1 commit intomainfrom
Open
Add tests for CLEAR COLUMN IN PARTITION in SummingMergeTree#128CarlosFelipeOR wants to merge 1 commit intomainfrom
CarlosFelipeOR wants to merge 1 commit intomainfrom
Conversation
Selfeer
reviewed
Apr 22, 2026
| try: | ||
| with Given("I create SummingMergeTree table with partition key"): | ||
| node.query( | ||
| f"CREATE TABLE {name} (v UInt64, p UInt64, c UInt64)" |
Collaborator
There was a problem hiding this comment.
It's best to reuse existing create table steps from helpers/create instead of creating a new query here - so the tests stay modular.
Collaborator
There was a problem hiding this comment.
You probably can reuse this:
clickhouse-regression/helpers/create.py
Line 201 in 0866740
| ) | ||
|
|
||
| with When("I insert data"): | ||
| node.query(f"INSERT INTO {name} VALUES (1, 1, 100)") |
Collaborator
There was a problem hiding this comment.
Same here - I would just crete a specific insert step either here or in steps.py and call that step here
| node.query(f"INSERT INTO {name} VALUES (2, 2, 200)") | ||
|
|
||
| with And("I update summing column to zero"): | ||
| node.query(f"ALTER TABLE {name} UPDATE c = 0 WHERE v = 1") |
Collaborator
There was a problem hiding this comment.
We also have alter steps under helpers/alter
Collaborator
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan