Update docker image, switch toolchain to llvm-22 with cmake-4.2#46
Conversation
Walkthrough该拉取请求将 Dockerfile 中的 LLVM 工具链固定为 clang-22 系列并通过签名 apt 源安装，显式安装 cmake v4.2.3，调整 Develop 阶段的 SSH 密钥处理与 zsh 环境，新增运行时工具；同时在 docker-compose.yml 中固定容器用户为 Changes
Sequence Diagram(s)（本次变更未引入需可视化的多组件顺序控制流，故省略序列图。） Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts (beta)
No actionable comments were generated in the recent review. 🎉 🧹 Recent nitpick comments
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@Dockerfile`:
- Around line 119-122: The Dockerfile installs cmake 4.2.3 into /opt/cmake/ but
the PATH export that would add /opt/cmake/bin is commented out, so the image
still uses the apt-installed cmake and wastes space; either remove the RUN block
that downloads/installs cmake into /opt/cmake/ to shrink the image, or enable
the PATH update so the new cmake is used (uncomment the PATH export that adds
/opt/cmake/bin), and ensure the chosen approach is consistent with the intent to
use cmake 4.2.3 or the system cmake.
- Around line 90-101: The RUN block that installs LLVM 22 should use the rolling
suite name instead of the non-existent "llvm-toolchain-noble-22" and follow the
project's apt install pattern: change the repo entry to "llvm-toolchain-noble"
(not "llvm-toolchain-noble-22"), add --no-install-recommends to the apt-get
install invocation for clang-22 clangd-22 clang-format-22 lldb-22, and after
installation clean apt caches (apt-get clean && rm -rf /var/lib/apt/lists/*) to
avoid leaving cache in the image; update-alternatives lines (for /usr/bin/clang,
clang++, clangd, clang-format, lldb) remain the same.
🧹 Nitpick comments (3)
Dockerfile (1)
137-137: 注释掉的代码应移除或恢复此行被注释掉但仍保留在 Dockerfile 中。结合上面的分析，如果需要 cmake 4.2.3，应取消注释使其生效；如果不需要，应连同第 119-122 行一起删除，避免留下无用的注释代码。
- # echo 'export PATH="${PATH}:/opt/cmake/bin"' >> ~/.zshrc && \ + echo 'export PATH="${PATH}:/opt/cmake/bin"' >> ~/.zshrc && \docker-compose.yml (2)
4-4: UID/GID 硬编码为 1000:1000此处将用户硬编码为
1000:1000，与 Dockerfile 中的ubuntu用户一致。但如果宿主机用户的 UID 不是 1000，挂载的文件可能会出现权限问题（例如.:/workspaces/RMCS目录）。考虑使用环境变量参数化：
- user: "1000:1000" + user: "${UID:-1000}:${GID:-1000}"这样默认行为不变，但允许 UID 不同的用户通过环境变量覆盖。
8-8: Wayland socket 路径也硬编码了 UID 1000与第 4 行同理，
/run/user/1000/wayland-0中的1000与宿主机用户 UID 绑定。如果参数化了用户 UID，此路径也应同步调整。
| # Install latest stable llvm-toolchain | ||
| RUN mkdir -p /etc/apt/keyrings && \ | ||
| wget -O - https://apt.llvm.org/llvm-snapshot.gpg.key | gpg -o /etc/apt/keyrings/llvm-snapshot.gpg --dearmor && \ | ||
| echo "deb [signed-by=/etc/apt/keyrings/llvm-snapshot.gpg] https://mirrors.tuna.tsinghua.edu.cn/llvm-apt/noble/ llvm-toolchain-noble-22 main" \ | ||
| | tee /etc/apt/sources.list.d/llvm.list && \ | ||
| apt-get update && \ | ||
| apt-get install -y clang-22 clangd-22 clang-format-22 lldb-22 && \ | ||
| update-alternatives --install /usr/bin/clang clang /usr/bin/clang-22 100 && \ | ||
| update-alternatives --install /usr/bin/clang++ clang++ /usr/bin/clang++-22 100 && \ | ||
| update-alternatives --install /usr/bin/clangd clangd /usr/bin/clangd-22 100 && \ | ||
| update-alternatives --install /usr/bin/clang-format clang-format /usr/bin/clang-format-22 100 && \ | ||
| update-alternatives --install /usr/bin/lldb lldb /usr/bin/lldb-22 100 |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
LLVM 22 apt packages availability apt.llvm.org 2025 2026
💡 Result:
- Yes—LLVM/Clang 22 APT packages are available on
apt.llvm.orgin the 2025–2026 timeframe. The repository explicitly lists active branches 20, 21, and 22, and documents that the rolling “snapshot” channel became 22 on Aug 4, 2025. [1] - On
apt.llvm.org, the default (rolling) packages are “currently version 22”, and the site shows direct install examples likeapt-get install clang-22 lldb-22 lld-22plus many*-22libraries/tools. [1] - Per-distro “-22” suite directories may not exist (yet) for some distros (example: Ubuntu Noble 24.04 lists
llvm-toolchain-noble,-17…-21, but no-22suite directory). In that case, LLVM 22 is expected via the distro’s rolling suite (e.g.,llvm-toolchain-noble) rather thanllvm-toolchain-noble-22. [3] - LLVM’s upstream release schedule shows the release/22.x branch created Jan 13, 2026 (with 22.1.0 scheduled Feb 24, 2026), which aligns with LLVM 22 being the “current” line during 2026. [2]
Sources: apt.llvm.org package repo/status & instructions [1], apt.llvm.org Noble suites index [3], LLVM upstream release schedule [2].
🏁 Script executed:
# Check the full context of the Dockerfile to verify patterns in other apt-get blocks
cat -n Dockerfile | head -150Repository: Alliance-Algorithm/RMCS
Length of output: 7393
🏁 Script executed:
# Search for other apt-get install patterns in the Dockerfile
rg "apt-get install" -A 1 DockerfileRepository: Alliance-Algorithm/RMCS
Length of output: 696
修正 LLVM 22 APT 源配置与 apt-get 安装选项
该 RUN 块存在两个问题：
-
错误的 LLVM suite 路径：Ubuntu Noble 24.04 的官方 apt.llvm.org 仓库中并不存在
llvm-toolchain-noble-22目录。LLVM 22 应通过滚动更新源llvm-toolchain-noble获取，否则apt-get update可能会失败。 -
缺少
--no-install-recommends和 apt 缓存清理：与文件中其他所有apt-get install块的模式不一致。缺少--no-install-recommends会安装不必要的推荐包，缺少清理步骤导致 apt 缓存残留在镜像层中。
🛠️ 建议修复
RUN mkdir -p /etc/apt/keyrings && \
wget -O - https://apt.llvm.org/llvm-snapshot.gpg.key | gpg -o /etc/apt/keyrings/llvm-snapshot.gpg --dearmor && \
- echo "deb [signed-by=/etc/apt/keyrings/llvm-snapshot.gpg] https://mirrors.tuna.tsinghua.edu.cn/llvm-apt/noble/ llvm-toolchain-noble-22 main" \
+ echo "deb [signed-by=/etc/apt/keyrings/llvm-snapshot.gpg] https://mirrors.tuna.tsinghua.edu.cn/llvm-apt/noble/ llvm-toolchain-noble main" \
| tee /etc/apt/sources.list.d/llvm.list && \
apt-get update && \
- apt-get install -y clang-22 clangd-22 clang-format-22 lldb-22 && \
+ apt-get install -y --no-install-recommends clang-22 clangd-22 clang-format-22 lldb-22 && \
update-alternatives --install /usr/bin/clang clang /usr/bin/clang-22 100 && \
update-alternatives --install /usr/bin/clang++ clang++ /usr/bin/clang++-22 100 && \
update-alternatives --install /usr/bin/clangd clangd /usr/bin/clangd-22 100 && \
update-alternatives --install /usr/bin/clang-format clang-format /usr/bin/clang-format-22 100 && \
- update-alternatives --install /usr/bin/lldb lldb /usr/bin/lldb-22 100
+ update-alternatives --install /usr/bin/lldb lldb /usr/bin/lldb-22 100 && \
+ apt-get autoremove -y && apt-get clean && \
+ rm -rf /var/lib/apt/lists/* /tmp/*🧰 Tools
🪛 Trivy (0.69.1)
[error] 91-101: 'apt-get' missing '--no-install-recommends'
'--no-install-recommends' flag is missed: 'mkdir -p /etc/apt/keyrings && wget -O - https://apt.llvm.org/llvm-snapshot.gpg.key | gpg -o /etc/apt/keyrings/llvm-snapshot.gpg --dearmor && echo "deb [signed-by=/etc/apt/keyrings/llvm-snapshot.gpg] https://mirrors.tuna.tsinghua.edu.cn/llvm-apt/noble/ llvm-toolchain-noble-22 main" | tee /etc/apt/sources.list.d/llvm.list && apt-get update && apt-get install -y clang-22 clangd-22 clang-format-22 lldb-22 && update-alternatives --install /usr/bin/clang clang /usr/bin/clang-22 100 && update-alternatives --install /usr/bin/clang++ clang++ /usr/bin/clang++-22 100 && update-alternatives --install /usr/bin/clangd clangd /usr/bin/clangd-22 100 && update-alternatives --install /usr/bin/clang-format clang-format /usr/bin/clang-format-22 100 && update-alternatives --install /usr/bin/lldb lldb /usr/bin/lldb-22 100'
Rule: DS-0029
(IaC/Dockerfile)
🤖 Prompt for AI Agents
In `@Dockerfile` around lines 90 - 101, The RUN block that installs LLVM 22 should
use the rolling suite name instead of the non-existent "llvm-toolchain-noble-22"
and follow the project's apt install pattern: change the repo entry to
"llvm-toolchain-noble" (not "llvm-toolchain-noble-22"), add
--no-install-recommends to the apt-get install invocation for clang-22 clangd-22
clang-format-22 lldb-22, and after installation clean apt caches (apt-get clean
&& rm -rf /var/lib/apt/lists/*) to avoid leaving cache in the image;
update-alternatives lines (for /usr/bin/clang, clang++, clangd, clang-format,
lldb) remain the same.
| # Install latest stable cmake for user ubuntu | ||
| RUN wget https://github.com/kitware/cmake/releases/download/v4.2.3/cmake-4.2.3-linux-x86_64.sh -O install.sh && \ | ||
| mkdir -p /opt/cmake/ && bash install.sh --skip-license --prefix=/opt/cmake/ --exclude-subdir && \ | ||
| rm install.sh |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
cmake 4.2.3 release
💡 Result:
CMake 4.2.3 was released and made available for download on January 29, 2026. [1][2]
- It is listed as the latest stable release on the official CMake download page. [3]
- The 4.2.3 section of the CMake 4.2 release notes says it introduces no changes to documented features or interfaces, only implementation updates (ecosystem support and/or regression fixes). [4]
- The release announcement’s shortlog highlights a small set of changes since 4.2.2, including a libarchive Windows path tolerance fix and a CUDA test fix. [1][2]
Sources: [1][2][3][4]
🏁 Script executed:
# Find the Dockerfile and read the specific lines mentioned
fd -type f -name "Dockerfile" | head -5Repository: Alliance-Algorithm/RMCS
Length of output: 237
🏁 Script executed:
# Find Dockerfile using git or direct fd
git ls-files | grep -i dockerfile
# If that doesn't work, try direct path
ls -la | grep -i dockerfileRepository: Alliance-Algorithm/RMCS
Length of output: 138
🏁 Script executed:
# Read the Dockerfile to check the specific lines mentioned
cat -n Dockerfile | sed -n '75,145p'Repository: Alliance-Algorithm/RMCS
Length of output: 3973
cmake 4.2.3 安装到 /opt/cmake/ 但未加入 PATH，且与 apt 安装的 cmake 重复
第 81 行已通过 apt-get install 安装了系统 cmake，第 120-122 行又将 cmake 4.2.3 安装到 /opt/cmake/。但第 137 行将 PATH 导出注释掉了，因此 /opt/cmake/bin 不会出现在 $PATH 中，用户实际使用的仍是 apt 安装的旧版本 cmake。
这意味着：
/opt/cmake/占用了镜像空间但未被使用- 如果 PR 目标是切换到 cmake 4.2.3，则 PATH 导出不应被注释
请确认意图：若确实需要 cmake 4.2.3，应取消注释第 137 行；若不需要，则应移除此 RUN 块以减小镜像体积。
🤖 Prompt for AI Agents
In `@Dockerfile` around lines 119 - 122, The Dockerfile installs cmake 4.2.3 into
/opt/cmake/ but the PATH export that would add /opt/cmake/bin is commented out,
so the image still uses the apt-installed cmake and wastes space; either remove
the RUN block that downloads/installs cmake into /opt/cmake/ to shrink the
image, or enable the PATH update so the new cmake is used (uncomment the PATH
export that adds /opt/cmake/bin), and ensure the chosen approach is consistent
with the intent to use cmake 4.2.3 or the system cmake.
There was a problem hiding this comment.
未来项目会引入 cxx module，这是预安装
There was a problem hiding this comment.
@creeper5820 理解了，感谢说明！既然是为未来引入 C++ modules 预先安装 cmake 4.2.3，这个做法是合理的。当项目开始使用 C++ modules 时，记得取消注释第 137 行的 PATH 导出，让新版本 cmake 生效即可。
提前准备好工具链可以避免后续重新构建镜像的麻烦。👍
✏️ Learnings added
Learnt from: creeper5820
Repo: Alliance-Algorithm/RMCS PR: 46
File: Dockerfile:120-123
Timestamp: 2026-02-13T01:59:45.655Z
Learning: In the RMCS project Dockerfile, cmake 4.2.3 is pre-installed to /opt/cmake/ for future C++ modules support. The PATH export is currently commented out and will be enabled when C++ modules are introduced to the project.
Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.
1 participant
PR摘要
Dockerfile 更新
LLVM 工具链升级至版本 22
apt-key迁移到使用签名的 keyring（/etc/apt/keyrings/llvm-snapshot.gpg）并使用专用 apt 镜像源clang-22、clangd-22、clang-format-22、lldb-22update-alternatives将 clang/clang++/clangd/clang-format/lldb 指向版本 22（优先级提高）CMake 升级与安装流程
/opt/cmake/运行时工具与服务器配置
tini、openssh-server、avahi-daemon、orphan-sysvinit-scripts，并添加相应的 SSH/服务器运行时配置环境与 shell 配置调整
env_setup.zsh的集成与 env_setup 文件复制，新增/调整 oh-my-zsh 集成与 PATH 导出其他
docker-compose.yml 更新
用户与权限简化
${CONTAINER_USER}）固定为1000:1000privileged: true卷挂载与格式调整
:bind）stdin_open: true周围的空行/格式其他