-
Notifications
You must be signed in to change notification settings - Fork 628
[Trigger,PWGHF] Add new trigger for non-prompt antideuterons from beauty #14756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Don't open a PR as ready for review if it doesn't pass the required checks. |
Please consider the following formatting changes to AliceO2Group#14756
|
Hi @MRazza879 thanks I will have a look! In the meantime, can you and @njacazio please clarify which is the difference wrt this other PR #14747? Am I wrong or is it a duplication? |
|
Ciao @fgrosa apologies for the confusion, it was just to have a common basis. The other one is closed now. |
fgrosa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @MRazza879 I am approving and merging so that we can start testing, but please take a look at the comments I posted and implement them in a second PR. Thanks a lot!
| } | ||
|
|
||
| const bool isTOFDe = std::abs(track.tofNSigmaDe()) < cfgTOFNsigma; | ||
| const bool isTPCDe = std::abs(track.tpcNSigmaDe()) < cfgTPCNsigma; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider to add the possibility to apply a selection on ITS PID Nsigma as well, even just a lower limit as done in the HF Filter
O2Physics/EventFiltering/PWGHF/HFFilterHelpers.h
Line 1033 in f04e9d2
| if (std::fabs(NSigmaTPC) > nSigmaCuts[0] || NSigmaITS < -nSigmaCuts[3]) { // Use TPC and ITS below the threshold, NSigmaITS for deuteron with a lower limit |
|
|
||
| #include "../filterTables.h" | ||
|
|
||
| #include "PWGLF/DataModel/LFParticleIdentification.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I am not mistaken this is not needed
| #include "PWGLF/DataModel/LFParticleIdentification.h" |
|
|
||
| #include "CCDB/BasicCCDBManager.h" | ||
| #include "CommonConstants/PhysicsConstants.h" | ||
| #include "DCAFitter/DCAFitterN.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not needed (please check also the other includes)
| #include "DCAFitter/DCAFitterN.h" |
Hi @fgrosa,
this PR is to add the filter we discussed on non-prompt antideuterons from beauty.
I considered the time ambiguities, please let me know if it's in line with what you suggested.
cc: @ercolessi