Skip to content

Conversation

@MRazza879
Copy link
Contributor

Hi @fgrosa,
this PR is to add the filter we discussed on non-prompt antideuterons from beauty.
I considered the time ambiguities, please let me know if it's in line with what you suggested.
cc: @ercolessi

@github-actions github-actions bot changed the title Add new trigger for non-prompt antideuterons from beauty [Trigger,PWGHF] Add new trigger for non-prompt antideuterons from beauty Feb 2, 2026
@vkucera
Copy link
Collaborator

vkucera commented Feb 2, 2026

Don't open a PR as ready for review if it doesn't pass the required checks.

Please consider the following formatting changes to AliceO2Group#14756
@fgrosa
Copy link
Collaborator

fgrosa commented Feb 2, 2026

Hi @MRazza879 thanks I will have a look! In the meantime, can you and @njacazio please clarify which is the difference wrt this other PR #14747? Am I wrong or is it a duplication?

@njacazio
Copy link
Collaborator

njacazio commented Feb 2, 2026

Ciao @fgrosa apologies for the confusion, it was just to have a common basis. The other one is closed now.

@MRazza879 MRazza879 marked this pull request as ready for review February 2, 2026 17:08
Copy link
Collaborator

@fgrosa fgrosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MRazza879 I am approving and merging so that we can start testing, but please take a look at the comments I posted and implement them in a second PR. Thanks a lot!

}

const bool isTOFDe = std::abs(track.tofNSigmaDe()) < cfgTOFNsigma;
const bool isTPCDe = std::abs(track.tpcNSigmaDe()) < cfgTPCNsigma;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider to add the possibility to apply a selection on ITS PID Nsigma as well, even just a lower limit as done in the HF Filter

if (std::fabs(NSigmaTPC) > nSigmaCuts[0] || NSigmaITS < -nSigmaCuts[3]) { // Use TPC and ITS below the threshold, NSigmaITS for deuteron with a lower limit


#include "../filterTables.h"

#include "PWGLF/DataModel/LFParticleIdentification.h"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I am not mistaken this is not needed

Suggested change
#include "PWGLF/DataModel/LFParticleIdentification.h"


#include "CCDB/BasicCCDBManager.h"
#include "CommonConstants/PhysicsConstants.h"
#include "DCAFitter/DCAFitterN.h"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed (please check also the other includes)

Suggested change
#include "DCAFitter/DCAFitterN.h"

@fgrosa fgrosa enabled auto-merge (squash) February 2, 2026 20:41
@fgrosa fgrosa merged commit b39923a into AliceO2Group:master Feb 2, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

5 participants