Skip to content

Conversation

@wuctlby
Copy link
Contributor

@wuctlby wuctlby commented Jan 31, 2026

No description provided.

@wuctlby wuctlby requested a review from a team as a code owner January 31, 2026 10:05
@github-actions
Copy link

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@wuctlby wuctlby enabled auto-merge (squash) January 31, 2026 10:06
@wuctlby
Copy link
Contributor Author

wuctlby commented Feb 2, 2026

Dear @jackal1-66 , could you please have a look at what causes the test errors? The error messages are not super clear to me. Thanks a lot!

@wuctlby
Copy link
Contributor Author

wuctlby commented Feb 2, 2026

Besides, the grid test with the same cfg and ini files is successful. I just put the link here https://alimonitor.cern.ch/catalogue/?path=%2Falice%2Fcern.ch%2Fuser%2Fc%2Fchuntai%2F%2FMC_production%2Fnew_OO%2Ftest_10k_OO_qcd_test-20260201-154720

@jackal1-66
Copy link
Collaborator

Ciao @wuctlby , something seems to be wrong on the framework side. I'm investigating what the problem might be

@jackal1-66
Copy link
Collaborator

I couldn't find anything clear in the framework. Other generators and tests seem to be working fine. @wuctlby could you please check that the replaceParticle function logic is working as expected? The issue seems to be triggered there. I would look also in the correct cycling over the iPart variable. I'm investigating why this works for specific tags (until 28 of January it seems) and it's broken in more recent ones. I'm asking the experts (@ktf) also if something minor has changed that could trigger the memory fault somehow. Pythia doesn't seem to be the issue (last version is from 8 months ago).

@wuctlby
Copy link
Contributor Author

wuctlby commented Feb 3, 2026

Ciao @jackal1-66 , thanks a lot for the checks. I will follow your suggestion and check it.

@wuctlby
Copy link
Contributor Author

wuctlby commented Feb 3, 2026

Hi @jackal1-66 , I submitted another PR #2258 for the test, while it's still failed. And the log shows it ends after this test ++ /sw/slc9_x86-64/O2DPG/2258-slc9_x86-64-local1/test/run_generator_tests.sh. So I tested it locally, the ouputs are listed below:

[O2/latest O2DPG/latest-master-o2] ~/alice/O2DPG/test $> bash run_generator_tests.sh 

################################
# Run O2DPG simulation testing #
################################

Following INI files will be tested:
  - /home/wuct/alice/O2DPG/MC/config/PWGHF/ini/GeneratorHF_D2H_ccbar_and_bbbar_gap2_QCDCR_OO.ini
  - /home/wuct/alice/O2DPG/MC/config/PWGHF/ini/GeneratorHF_D2H_ccbar_and_bbbar_gap2_QCDCR_pO.ini
Checking /home/wuct/alice/O2DPG/MC/config/PWGHF/ini/GeneratorHF_D2H_ccbar_and_bbbar_gap2_QCDCR_OO.ini
Test 0: /home/wuct/alice/O2DPG/MC/config/PWGHF/ini/GeneratorHF_D2H_ccbar_and_bbbar_gap2_QCDCR_OO.ini with generator External -> PASSED
Checking /home/wuct/alice/O2DPG/MC/config/PWGHF/ini/GeneratorHF_D2H_ccbar_and_bbbar_gap2_QCDCR_pO.ini
Test 1: /home/wuct/alice/O2DPG/MC/config/PWGHF/ini/GeneratorHF_D2H_ccbar_and_bbbar_gap2_QCDCR_pO.ini with generator External -> PASSED

All generator tests successful

It seems to be successful, but there are some warnings, such as [09:25:19][WARN] Particle to be tracked is not defined in PDG: pdg = 1000000069 (disabling tracking). In my opinion, this should not affect the final test result.

@jackal1-66
Copy link
Collaborator

Ciao @wuctlby , I also tested it locally with a more recent tag and it fails. I had luck with the cvmfs daily tag of the 28 of January, but something seems wrong.

@wuctlby
Copy link
Contributor Author

wuctlby commented Feb 3, 2026

Ciao @wuctlby , I also tested it locally with a more recent tag and it fails. I had luck with the cvmfs daily tag of the 28 of January, but something seems wrong.

Okay, I would rebuild the whole framework with the lastest tag, and let' see. Besides, I also had a look at the replaceParticle function. In princelple, it should not be triggered for these OO and pO cases.

@jackal1-66
Copy link
Collaborator

Found the issue, it's unrelated to your PR. I'll prepare a fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants