Conversation
Member
ktf
commented
Jun 11, 2025
- Drop our own private copy of the headers
- Use the CMake Config
- Drop our own private copy of the headers - Use the CMake Config ***
Member
Author
|
@davidrohr as discussed in the meeting. This seems to compile fine. |
Collaborator
|
Looks good to me. However, in the past we also regularly needed to adapt the ClangTidyMain.cpp when the APIs changed. Not sure, has that stabilized now that it is a public API? |
Member
Author
|
I do not know, I wouldn't be surprised if it was still unstable as an API. However it's not different from adapting to fair::mq / ROOT changes, no? I would tackle it as we do for other stuff, whenever clang gets updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.