fix(session): enforce 20-char display name cap on rename#2383
Open
aprv10 wants to merge 2 commits into
Open
Conversation
harshitsinghbhandari
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2375
What this fixes
Backend only — no frontend change.
displayNameat 20 runes (DISPLAY_NAME_TOO_LONG), but the rename path had no length check at any layer, soao session renameandPATCH /sessions/{id}accepted and persisted names spawn would have rejected.Service.Rename, so all three callers(the PATCH endpoint,ao session rename, and the sidebar inline-rename) inherit it and return the sameDISPLAY_NAME_TOO_LONGerror as spawn.maxLength={20}is unchanged. Therename-session.tscomment claiming the daemon enforces this cap is now accurate.Testing
go build ./...clean;go test ./internal/service/session/ ./internal/httpd/controllers/passes.TestSessionRenameRejectsTooLongDisplayName: a 21-character rename is rejected withapierr.Invalid/DISPLAY_NAME_TOO_LONGand the stored name is left unchanged, mirroring the existingTestSessionsAPI_SpawnDisplayNameTooLongon the spawn path.Files
backend/internal/service/session/service.gobackend/internal/service/session/service_test.go