Feat/webhook linear by twelvearrays · Pull Request #230 · AgentWrapper/agent-orchestrator

twelvearrays · 2026-02-27T16:12:12Z

No description provided.

@deprecated

Add protocol-agnostic McpInputSource interface to replace the Tracker plugin for issue context resolution. Any MCP server (Linear, GitHub, Notion, custom) can now drive agent spawning. New types: McpInputSource, AgentContext, AgentContextComment, Resource. Existing Tracker interface kept with @deprecated annotation for backward compatibility.

Add 9th plugin slot: McpToolPlugin for injecting scoped MCP tool surfaces into spawned agent sessions. Also adds: - ReactionType union type with all known reaction types - 'hardware-test-required' reaction for hardware-dependent plugins - 'queue-for-hardware' action type for ReactionConfig - McpEntry schema validated via Zod (requires plugin or name+url) - McpServerConfig, HealthResult types Config schema validates mcp array entries: rejects invalid URLs, invalid scope values, and entries missing both plugin and name+url.

…-867)

# Conflicts: # packages/core/src/index.ts

…rompt

…reaction

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fdf28043c8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-02-27T16:17:34Z

+  const previousLabelIds = payload.updatedFrom?.labelIds;
+  if (previousLabelIds && previousLabelIds.includes(matchingLabel.id)) {
+    return false;
+  }
+
+  return true;


Require labelIds change before firing label trigger

wasLabelAdded treats a missing updatedFrom.labelIds as a newly added label, so any non-label Issue update that still includes the label in data.labels will retrigger the automation path. In Linear webhooks, updatedFrom commonly omits fields that did not change, so this can repeatedly spawn/send actions whenever the dedup window expires even though no label transition happened.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-02-27T16:17:34Z

+  const previousState = payload.updatedFrom?.state;
+
+  if (!currentState || currentState.type !== "completed") return false;
+  if (previousState?.type === "completed") return false;


Gate completed-state trigger on an actual state transition

wasMovedToCompleted returns true whenever the current state is completed and updatedFrom.state is absent, which means later unrelated Issue updates on already-completed items can keep triggering test-generation. Because this check runs on every Issue/update webhook, completed issues can repeatedly enqueue test-gen runs after dedup timeout without any new state change.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-02-27T16:17:34Z

+      const res = await fetch(healthUrl, {
+        signal: AbortSignal.timeout(3000),
+      });


Pass configured auth when probing MCP server health

UrlMcpToolPlugin.healthCheck probes the endpoint without any auth headers, but many MCP servers require credentials to return 2xx. In those setups this check marks otherwise-usable plugins unhealthy, and injectMcpConfig then excludes them from .mcp.json, causing agents to start without expected MCP tools despite valid runtime credentials being configured in env.

Useful? React with 👍 / 👎.

cursor

Cursor Bugbot has reviewed your changes and found 5 potential issues.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

cursor · 2026-02-27T16:21:35Z

+
+  const testGenPromptFile = resolve(
+    process.env["TEST_GEN_PROMPT_FILE"] ?? resolve(__dirname, "../../test-gen-prompt.md"),
+  );


Wrong relative path breaks server startup

High Severity

The default path for test-gen-prompt.md uses "../../test-gen-prompt.md" relative to __dirname, but after compilation __dirname is the dist/ directory. Going up two levels from packages/webhook-linear/dist/ lands at packages/, not packages/webhook-linear/ where test-gen-prompt.md actually lives. The correct relative path is "../test-gen-prompt.md". Without the TEST_GEN_PROMPT_FILE env var set, loadConfig() will throw on startup, crashing the server.

cursor · 2026-02-27T16:21:35Z

+    return false;
+  }
+
+  return true;


Label detection triggers on any issue update

Medium Severity

wasLabelAdded returns true whenever the target label is present on the issue and updatedFrom.labelIds is absent. Linear webhooks only include labelIds in updatedFrom when labels actually changed. So any non-label update (title edit, assignee change, etc.) to an issue that already has the trigger label will incorrectly be treated as a new label addition, causing spurious agent spawns.

cursor · 2026-02-27T16:21:35Z

+  url?: string;
+  auth?: { type: "bearer"; token: string };
+  toolMap?: Record<string, unknown>;
+}


Duplicated InputSourceConfig type across two files

Low Severity

InputSourceConfig is defined identically in both resolve-input-source.ts and types.ts. The file already imports ProjectConfig from ./types.js, so it can import InputSourceConfig from there as well instead of re-declaring it. Maintaining two copies risks them diverging silently.

Additional Locations (1)

packages/core/src/types.ts#L998-L1005

^{Triggered by project rule: BugBot Configuration}

cursor · 2026-02-27T16:21:35Z

+  if (previousState?.type === "completed") return false;
+
+  return true;
+}


Completed-state detection triggers on any issue update

Medium Severity

wasMovedToCompleted has the same false-positive pattern as wasLabelAdded. When updatedFrom exists but doesn't include state (because a non-state field like title or description was edited), previousState is undefined, the previousState?.type === "completed" check passes, and the function returns true. Any edit to an already-completed issue (description tweak, label change, etc.) would incorrectly trigger a test-gen agent spawn.

cursor · 2026-02-27T16:21:35Z

+        hardwareReaction = reaction;
+      }
+    }
+  }


Crashed health check silently treated as healthy

Medium Severity

When a plugin's healthCheck throws (promise rejects), the for loop skips it via continue on line 42, so the plugin is never added to failedPlugins. Since failedNames is built from failedPlugins, the crashing plugin passes the healthy filter on line 63 and gets written to .mcp.json as if it were healthy. A plugin that explicitly defines a healthCheck but crashes during the check ends up being treated identically to a plugin with no health check at all.

* feat(session): support multiple PRs per session A session can now own several pull requests (a root plus stacked children) instead of being capped at one. The SQLite schema was already 1-session->many-PR (pr.url PK, session_id a plain FK), so this is a behavioural change across the observe -> persist -> derive -> react pipeline, not a migration. - observe: the SCM observer discovers every open PR whose source branch matches a session branch or descends from it ("branch/..." stacking), attributing each to the owning session; the longest matching branch wins so a child session claims its own stacked PRs. - derive: session status is a worst-wins aggregate over all owned PRs, with a stack model (B is a child of A iff B.target == A.source and A is open) exposed via prs[] on every session read DTO. - react: per-PR reactions; a stacked child blocked by an open parent is exempt from the rebase/merge-conflict nudge (only the bottom of the stack is eligible), and the session completes only when no PR is open and at least one merged. - tests: unit coverage across stack/status/observer/lifecycle, a real-SQLite ListPRFactsForSession test for the stacked-PR read path, and a functional end-to-end integration test driving the real store + lifecycle + observer through attribution, completion, and stacked-child nudge suppression. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(scm): ignore fork heads in PR attribution and persist discovered siblings before completion Branch-prefix attribution now requires a discovered PR's head branch to live in the project repo. A fork PR can reuse a session's branch name while its commits live in the fork, so the previous code could auto-claim foreign work. Carry head repo full_name from the REST list response and skip any PR whose head repo is not the base repo. discoverNewPRs also writes each newly discovered PR as an open baseline row before the refresh/lifecycle pass runs. A session can own several PRs, and a terminal observation triggers a completion check that reads all of the session's PRs from the store. Without the early write, an open sibling found in the same poll was not yet durable and the session could terminate while that PR was still open. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(session): surface actionable signals from blocked stacked children; clarify worker prompt Status aggregation previously dropped any open PR blocked by an open parent, hiding actionable child signals (failing CI, draft, requested changes, unresolved comments) behind the parent's status. A blocked child still cannot merge, so its readiness signals (mergeable/approved/review-pending/open) stay suppressed, but its problem signals now contribute to the worst-wins aggregate. The all-blocked fallback is preserved so a session never goes dark. The worker multi-PR prompt said independent PRs could branch off the base branch as usual, which conflicts with branch-prefix attribution. Clarify that a PR may target the base branch, but its source branch must stay under the session branch namespace for AO to track it. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>

twelvearrays added 25 commits February 24, 2026 17:26

Merge branch 'feat/pos-872-mcp-tool-plugin-interface'

041d8c1

feat(linear): implement McpInputSource via Linear MCP protocol (POS-869)

41a98c0

feat(session): inject scoped .mcp.json at session init (POS-873)

721b902

feat(core): GenericMcpInputSource adapter (POS-870)

93e691c

feat(plugins): DejavooPlugin, PowerSyncPlugin, SupabasePOSPlugin (POS…

10d05df

…-867)

Merge branch 'feat/pos-870-generic-mcp-input-source'

1c6e301

Merge branch 'feat/pos-873-session-mcp-injection'

81ea78b

# Conflicts: # packages/core/src/index.ts

Merge branch 'feat/pos-867-pos-mcp-plugins'

2224e3a

feat(cli): source:id syntax in ao spawn (POS-871)

1aa3efc

test(linear): fill coverage gaps in LinearMcpInputSource

051b82a

test(core): fill coverage gaps in MCP injection and generic input source

11e6088

Merge branch 'test/fill-linear-mcp-coverage-gaps'

fae6712

feat(webhook-linear): scaffold package

ee92eac

feat(webhook-linear): add types and config module

6aeb86e

feat(webhook-linear): add event detection with tests

296afd0

feat(webhook-linear): add timing-safe signature verification

467f6c1

feat(webhook-linear): add dedup tracker with tests

0fd6ea1

feat(webhook-linear): add example config, agent-rules, and test-gen p…

401ee24

…rompt

feat(webhook-linear): add spawn helpers with tests

8404587

feat(webhook-linear): assemble Express server

2b97f6e

feat(webhook-linear): add issue state transitions and approved-green …

f077e9f

…reaction

feat(webhook-linear): add qa-passed label trigger for merge instruction

255f637

chore(webhook-linear): fill in label and state UUIDs from Linear

fdf2804

twelvearrays closed this Feb 27, 2026

chatgpt-codex-connector Bot reviewed Feb 27, 2026

View reviewed changes

cursor Bot reviewed Feb 27, 2026

View reviewed changes

abhay-codes07 mentioned this pull request Jul 3, 2026

bug(session): terminated session reports merged while it still owns an open PR #2390

Open

abhay-codes07 mentioned this pull request Jul 3, 2026

fix(session): keep terminated status when an open PR remains #2392

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/webhook linear#230

Feat/webhook linear#230
twelvearrays wants to merge 25 commits into
AgentWrapper:mainfrom
twelvearrays:feat/webhook-linear

twelvearrays commented Feb 27, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Feb 27, 2026

Uh oh!

chatgpt-codex-connector Bot Feb 27, 2026

Uh oh!

chatgpt-codex-connector Bot Feb 27, 2026

Uh oh!

cursor Bot left a comment

Uh oh!

cursor Bot Feb 27, 2026

Uh oh!

cursor Bot Feb 27, 2026

Uh oh!

cursor Bot Feb 27, 2026

Uh oh!

cursor Bot Feb 27, 2026

Uh oh!

cursor Bot Feb 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

twelvearrays commented Feb 27, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor Bot Feb 27, 2026

Choose a reason for hiding this comment

Wrong relative path breaks server startup

Uh oh!

cursor Bot Feb 27, 2026

Choose a reason for hiding this comment

Label detection triggers on any issue update

Uh oh!

cursor Bot Feb 27, 2026

Choose a reason for hiding this comment

Duplicated InputSourceConfig type across two files

Uh oh!

cursor Bot Feb 27, 2026

Choose a reason for hiding this comment

Completed-state detection triggers on any issue update

Uh oh!

cursor Bot Feb 27, 2026

Choose a reason for hiding this comment

Crashed health check silently treated as healthy

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Duplicated `InputSourceConfig` type across two files