feat(python): expose annotation read/write API on Bookmark#264
Merged
tedwaine merged 1 commit intoMay 29, 2026
Merged
Conversation
Register get_annotation_atom, annotation_data_atom and build_annotation_atom in py_atoms.cpp. Add three accessors to Bookmark: has_annotation (bool property), annotation_data (read-only serialise-based property returning the canvas dict), and set_annotation() which constructs a JsonStore payload and sends it via add_annotation_atom. Bypasses the AnnotationsCore undo stack intentionally, which is correct for sync/remote-write use cases. Signed-off-by: Sam.Richards@taurich.org <Sam.Richards@taurich.org> (cherry picked from commit 964d1e294374b0bed9df8881b3a205b16513100b)
tedwaine
merged commit 82daad4
into
AcademySoftwareFoundation:develop
2 of 3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Register get_annotation_atom, annotation_data_atom and build_annotation_atom in py_atoms.cpp. Add three accessors to Bookmark: has_annotation (bool property), annotation_data (read-only serialise-based property returning the canvas dict), and set_annotation() which constructs a JsonStore payload and sends it via add_annotation_atom. Bypasses the AnnotationsCore undo stack intentionally, which is correct for sync/remote-write use cases.
(cherry picked from commit 964d1e294374b0bed9df8881b3a205b16513100b)
Linked issues
Summarize your change.
Describe the reason for the change.
Describe what you have tested and on which operating system.
Add a list of changes, and note any that might need special attention during the review.
If possible, provide screenshots.