docs: clarify bundle tests mock network and model downloads#184
Merged
rosspeili merged 2 commits intoJun 23, 2026
Merged
Conversation
Contributor
|
Thanks @katebabakova444, this closes #170 cleanly. LGTM once CI passes. Suggested polish: blank line before Nice, focused doc PR, appreciate it, and welcome <3 |
Contributor
Author
|
Thanks! Added the TESTING.md spacing polish and Unreleased changelog entry. |
Contributor
|
Merged in main. Thank you for this clean take. Feel free to explore more good first issues, or suggest issues or new skills if you're using the framework. <3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarifies that bundle tests run in CI and must not make live network calls, use API keys, or download models.
Updates documentation to explicitly mention mocking:
Also notes that real inference belongs in maintainer tests or local/manual runs, not bundle CI gates.
Related issue
Closes #170