Skip to content

docs: clarify bundle tests mock network and model downloads#184

Merged
rosspeili merged 2 commits into
ARPAHLS:mainfrom
katebabakova444:docs/mock-network-model-downloads
Jun 23, 2026
Merged

docs: clarify bundle tests mock network and model downloads#184
rosspeili merged 2 commits into
ARPAHLS:mainfrom
katebabakova444:docs/mock-network-model-downloads

Conversation

@katebabakova444

Copy link
Copy Markdown
Contributor

Clarifies that bundle tests run in CI and must not make live network calls, use API keys, or download models.
Updates documentation to explicitly mention mocking:

  • HTTP clients
  • LLM clients
  • embedding/model loaders
  • first-run model downloads
    Also notes that real inference belongs in maintainer tests or local/manual runs, not bundle CI gates.

Related issue

Closes #170

@rosspeili rosspeili self-requested a review June 23, 2026 17:00
@rosspeili

Copy link
Copy Markdown
Contributor

Thanks @katebabakova444, this closes #170 cleanly.

LGTM once CI passes. Suggested polish: blank line before ### Framework test in TESTING.md, and a one-line [Unreleased] Documentation entry in CHANGELOG if you want full PR checklist parity.

Nice, focused doc PR, appreciate it, and welcome <3

@katebabakova444

Copy link
Copy Markdown
Contributor Author

Thanks! Added the TESTING.md spacing polish and Unreleased changelog entry.

@rosspeili rosspeili merged commit 1675d9d into ARPAHLS:main Jun 23, 2026
5 checks passed
@rosspeili

Copy link
Copy Markdown
Contributor

Merged in main. Thank you for this clean take. Feel free to explore more good first issues, or suggest issues or new skills if you're using the framework. <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Docs]: Clarify bundle tests must mock network and model downloads in CI

2 participants