Add FEAT_CMH support#430
Conversation
Following changes to PCDPHINT update ACLE description
| These intrinsics provide some atomic fetch operations, which will | ||
| make use of hint instructions immediately followed by the | ||
| associated fetch instructions. These intrinsics are type generic and | ||
| supports scalar integral and floating-point types of 8, 16, 32, and 64 bits. |
There was a problem hiding this comment.
floating point??? Let's stick to scalar integer only. I don't believe there is any use of FP variants anyway.
There was a problem hiding this comment.
I think the idea was to be consistent with the store intrinsic. Or is there a reason to have different type support between the 2 ?
There was a problem hiding this comment.
Since it can't be done on compare&exchange loops, you'd have to check that for all architectures where CMH is allowed that FP atomics are a must-have and not optional. It's complex.
There was a problem hiding this comment.
Happy to remove from the fetch and leave on the store, the lack of consistency may be confusing but I doubt it will be used much tbh
There was a problem hiding this comment.
We don't have a good way to emit the instruction yet without the hint... I think it's best done separately since it only applies when FEAT_LSFE is available. Note LSFE also defines lots LDFMIN/MAX variants.
There was a problem hiding this comment.
Sure, but with the hint it will have to be emitted by a builtin in any case. So unless you want to have 2 separate hint builtins 1 for integer and 1 for floating point type it will need to be added here. Regarding the feature constraint integer variant is also guarded by FEAT_LSE.
But if you have strong preference for separating codegen fo FEAT_LSFE instructions to separate work, we can leave it be for now and extend later.
Hi all,
This is a PR to propose the addition of new intrinsics required as part of FEAT_CMH.
Quality Level: ALP
Thank you for submitting a pull request!
If this PR is about a bugfix:
Please use the bugfix label and make sure to go through the checklist below.
If this PR is about a proposal:
We are looking forward to evaluate your proposal, and if possible to
make it part of the Arm C Language Extension (ACLE) specifications.
We would like to encourage you reading through the contribution
guidelines, in particular the section on submitting
a proposal.
Please use the proposal label.
As for any pull request, please make sure to go through the below
checklist.
Checklist: (mark with
Xthose which apply)PR (do not bother creating the issue if all you want to do is
fixing the bug yourself).
SPDX-FileCopyrightTextlines on topof any file I have edited. Format is
SPDX-FileCopyrightText: Copyright {year} {entity or name} <{contact informations}>(Please update existing copyright lines if applicable. You can
specify year ranges with hyphen , as in
2017-2019, and usecommas to separate gaps, as in
2018-2020, 2022).Copyrightsection of the sources of thespecification I have edited (this will show up in the text
rendered in the PDF and other output format supported). The
format is the same described in the previous item.
tricky to set up on non-*nix machines). The sequence can be
found in the contribution
guidelines. Don't
worry if you cannot run these scripts on your machine, your
patch will be automatically checked in the Actions of the pull
request.
introduced in this PR in the section Changes for next
release of the section Change Control/Document history
of the document. Create Changes for next release if it does
not exist. Notice that changes that are not modifying the
content and rendering of the specifications (both HTML and PDF)
do not need to be listed.
correctness of the result in the PDF output (please refer to the
instructions on how to build the PDFs
locally).
draftversionis set totruein the YAML headerof the sources of the specifications I have modified.
in the README page of the project.