build: scripts/verify-strict.sh — single-command 95/75 coverage gate#13
Conversation
Wrapper script hardcodes the 95% line / 75% branch coverage thresholds
(plus markdown summary + generated-code exclusion) and forwards extra args
to ./build.sh Verify. The coverage-push inner loop now reads as a single
muscle-memory command instead of a four-flag invocation.
docs/COVERAGE-HANDOFF.md is updated in all three sections (framing,
fenced prompt block, syntax notes) so a fresh chat picks up the wrapper
without re-deriving the thresholds.
Trade-off acknowledged in syntax notes: the script stays outside NUKE's
discoverability ('./build.sh --plan' won't list it). Once
.github/workflows/ci.yml ratchets to 95/75, CI can call the wrapper and
the threshold lives in exactly one place.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (2)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
There was a problem hiding this comment.
Pull request overview
This PR adds a small convenience wrapper to run the NUKE Verify target with a fixed “strict” DotCov coverage gate (95% line / 75% branch), and updates the coverage handoff documentation to use that wrapper as the single inner-loop command.
Changes:
- Added
scripts/verify-strict.shto run./build.sh Verifywith 95/75 thresholds, markdown output, and generated-code exclusion. - Updated
docs/COVERAGE-HANDOFF.mdto direct contributors to use the wrapper for the coverage-push workflow.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| scripts/verify-strict.sh | Adds a strict-coverage wrapper around ./build.sh Verify with fixed DotCov parameters and arg forwarding. |
| docs/COVERAGE-HANDOFF.md | Updates the handoff prompt and syntax notes to use/document the new wrapper script. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
scripts/verify-strict.sh— a thin wrapper that prepends--coverage-min-line 95 --coverage-min-branch 75 --coverage-format markdown --coverage-exclude-generated-param trueto./build.sh Verifyand forwards extra args.docs/COVERAGE-HANDOFF.md(framing, fenced prompt block, syntax notes) to use the wrapper for the coverage-push inner loop.The wrapper is option c) of the three approaches considered:
VerifyStrictNUKE target shelling todotcovdirectly — violates Pipeline's "no raw CLI" cohesion bar.Build/ICoverageReportbaking 95/75 globally — clean, but couples the threshold to NUKE defaults and ties the loose-floor CI command to CLI overrides..github/workflows/ci.ymlratchets to 95/75.Trade-off documented in the handoff doc: the wrapper is outside
./build.sh --plandiscoverability — bought back by a single muscle-memory command during the cluster push.Test plan
bash -n scripts/verify-strict.shis syntax-clean (verified locally)../scripts/verify-strict.sh --helpforwards through to./build.sh Verify --help(extra-args pass-through).docs/COVERAGE-HANDOFF.mdend-to-end; fenced block (lines 14–58) is what a fresh chat pastes — confirm the inner-loop line is the only command needed.Build & Test (backend)(this PR does not touch CI thresholds; that's the final ratchet PR per the handoff doc).🤖 Generated with Claude Code