Skip to content

fix constrained model run errors#282

Merged
gareth-j merged 1 commit intoconstrainedModelfrom
Fix_constrainedModel
Nov 23, 2023
Merged

fix constrained model run errors#282
gareth-j merged 1 commit intoconstrainedModelfrom
Fix_constrainedModel

Conversation

@XueqingYin
Copy link
Copy Markdown
Contributor

@XueqingYin XueqingYin commented Nov 23, 2023

  • Summary of changes (Bug fix, feature, docs update, ...)
    To fix the errors when running the constrained model.
  1. Put ‘data= simdf_time’ inside the function like( ).
  2. Delete ‘marginal = bru_mapper_marginal(qexp, rate = 1)’, ‘group_mapper = bru_mapper(mesh)’, and ‘qexp <- stats::qnorm(p, mean = 0, sd = 1, lower.tail = TRUE, log.p = FALSE)’ simply because they keep reporting errors.
  • Please check if the PR fulfills these requirements
  • Closes #xxxx (replace xxxx with the GitHub issue number)
  • Tests added and passed
  • All code checks passing - styler run over code
  • Vignettes updated/added
  • Added an entry in the latest CHANGELOG.md file if fixing a bug or adding a new feature
  • Any new libraries added to DESCRIPTION

1. Put ‘data= simdf_time’ inside the function like( ). 
2. Delete ‘marginal = bru_mapper_marginal(qexp, rate = 1)’, ‘group_mapper = bru_mapper(mesh)’, and ‘qexp <- stats::qnorm(p, mean = 0, sd = 1, lower.tail = TRUE, log.p = FALSE)’ simply because they keep reporting errors.
@XueqingYin XueqingYin requested a review from gareth-j November 23, 2023 12:09
Copy link
Copy Markdown
Contributor

@gareth-j gareth-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gareth-j gareth-j merged commit 3204f99 into constrainedModel Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants