Rename siteId to zoneID - #102
Open
carlosfelix wants to merge 4 commits into
Open
Conversation
|
Tread carefully! This PR adds 3 linter errors (possibly disabled through directives):
|
carlosfelix
force-pushed
the
33across_adapter_maintenance
branch
from
August 21, 2025 17:31
72a7b8b to
834d6f4
Compare
carlosfelix
changed the title
|
Tread carefully! This PR adds 2 linter errors (possibly disabled through directives):
|
carlosfelix
changed the title
Collaborator
|
Changes look good, there's a couple of lint related messages github is complaining about We will still read the siteid field for cases where publishers are using an older pbjs version and have not updated their configuration so it doesn't break their integration? |
carlosfelix
force-pushed
the
33across_adapter_maintenance
branch
from
August 27, 2025 20:44
834d6f4 to
4b6ef98
Compare
carlosfelix
force-pushed
the
33across_adapter_maintenance
branch
from
September 9, 2025 17:50
4b6ef98 to
58938f0
Compare
carlosfelix
force-pushed
the
33across_adapter_maintenance
branch
from
September 11, 2025 16:03
25e3ae4 to
3c0f144
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://33across.atlassian.net/browse/XCH-3325