Fix palette resolution#605
Merged
Merged
Conversation
The LayerProp palette lookup was gated on the *filter* attribute instead of the *palette* attribute -- the filter checks from the line above were copy-pasted verbatim. As a result, any LayerProp with an empty filter but a real palette never resolved its palette table: paletteTable stayed NULL and the layer fell back to the merc's shade table. The most visible victim is the heli fast-rope arrival layer (filter="" palette="hats"): rendered with the merc palette, the rope's pixel indices (45-81, 166-172) hit the merc's unreplaced orange/red glow ramp instead of the rope's own tan/green, painting orange specks along the rope. Testing the palette attribute restores the intended "hats" palette and the correct rope colours; it also fixes any other empty-filter layers. Co-Authored-By: Claude Opus 4.7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The LayerProp palette lookup was gated on the filter attribute instead of the palette attribute -- the filter checks from the line above were copy-pasted verbatim. As a result, any LayerProp with an empty filter but a real palette never resolved its palette table: paletteTable stayed NULL and the layer fell back to the merc's shade table.
The most visible victim is the heli fast-rope arrival layer (filter="" palette="hats"): rendered with the merc palette, the rope's pixel indices (45-81, 166-172) hit the merc's unreplaced orange/red glow ramp instead of the rope's own tan/green, painting orange specks along the rope. Testing the palette attribute restores the intended "hats" palette and the correct rope colours; it also fixes any other empty-filter layers.
Co-Authored-By: Claude Opus 4.7