Skip to content

Fix SseServerWrapper to support port 0 (OS auto-assign) #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
x9090 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix SseServerWrapper to support port 0 (OS auto-assign) #38

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e15f419
Fix SseServerWrapper to support port 0 (OS auto-assign)
x9090 Mar 10, 2026
08b50d1
More complete fix
x9090 Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions src/server/sse_server.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,8 +255,8 @@ void SseServerWrapper::send_event_to_session(const std::string& session_id,

void SseServerWrapper::run_server()
{
// Just run the server - routes are already set up
svr_->listen(host_.c_str(), port_);
// Just run the server - bind was already done in start()
svr_->listen_after_bind();
running_ = false;
}

Expand Down Expand Up @@ -557,6 +557,21 @@ bool SseServerWrapper::start()
}
});

// Bind synchronously to get actual port (supports port 0 / OS auto-assign).
// bind_to_any_port() returns the assigned port; bind_to_port() returns bool.
if (port_ == 0)
{
int bound_port = svr_->bind_to_any_port(host_);
if (bound_port <= 0)
return false;
port_ = bound_port;
}
else
{
if (!svr_->bind_to_port(host_, port_))
return false;
}

running_ = true;

thread_ = std::thread([this]() { run_server(); });
Expand Down