handle rate limit and implement retry logic#213
Merged
smaeda-ks merged 6 commits intoxdevplatform:masterfrom Aug 20, 2019
Merged
handle rate limit and implement retry logic#213smaeda-ks merged 6 commits intoxdevplatform:masterfrom
smaeda-ks merged 6 commits intoxdevplatform:masterfrom
Conversation
jbabichjapan
reviewed
Aug 7, 2019
smaeda-ks
commented
Aug 8, 2019
| def test_rate_limit_handle_with_retry_success_1(monkeypatch): | ||
| # scenario: | ||
| # - 500 (retry) -> 429 (handle rate limit) -> 200 (end) | ||
| monkeypatch.setattr(time, 'sleep', lambda s: None) |
Contributor
Author
There was a problem hiding this comment.
monkeypatch to stub time.sleep() in http.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding rate limit handling and retry logic.
Usage
Test with actual requests