Fix LlamaFirewall scans inside the MCP event loop - #54
Open
3nesdeniz wants to merge 1 commit into
Open
Conversation
Signed-off-by: Enes Deniz <142517728+3nesdeniz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scan_async()API for server configurations and tool responsesFixes #39.
Root cause
mcp-context-protectorexecutes guardrail checks inside its active asyncio event loop.LlamaFirewall.scan()starts another event loop withasyncio.run(), so both the configuration-review and tool-response paths could fail with:LlamaFirewall provides
scan_async()for this environment. The provider contract and both call chains now await that API directly.Verification
mainbranch with the official MCP Python weather server.get_alertstool call after the fix.302 passed13 passedon each versionmake lint: Ruff formatting/checks and 100% interrogate coverage passeduv build: source distribution and wheel built successfullygit diff --check: passed