From 1133af28e847cccf2d83050c0a7d1717275de144 Mon Sep 17 00:00:00 2001 From: Thomas Luizon Rodrigues Gregorio Date: Mon, 13 Jul 2026 12:56:51 -0300 Subject: [PATCH] chore(ci): exclude email templates and load-tests from SonarCloud MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Append two entries to sonar.exclusions in the SonarScanner Begin step: - **/Email/Templates/**: HTML-email templates. Web:S1827 (cellspacing), Web:S6819 (role=presentation over ) and Web:S5257 (layout tables) are false positives here — table layout, cellspacing/cellpadding and role="presentation" are the required cross-client techniques for HTML email (Outlook/legacy clients lack CSS-layout support). Static assets with no maintainability value to analyze. - **/load-tests/**: k6 load-test scenario scripts — developer tooling, not shipped product code (parity with the existing **/.claude/** exclusion). Clears the open javascript:* smells under load-tests/. Refs thomasluizon/orbit-ui-mobile#243 Co-Authored-By: Claude Opus 4.8 (1M context) --- .github/workflows/sonarcloud.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/sonarcloud.yml b/.github/workflows/sonarcloud.yml index ba7bda88..061a912c 100644 --- a/.github/workflows/sonarcloud.yml +++ b/.github/workflows/sonarcloud.yml @@ -68,6 +68,9 @@ jobs: # DROPPED (now in coverage): Services/AppConfigService.cs (pure ConvertValue + injectable cache/repo) and # Services/UserDateService.cs (user-timezone "today" + week-start, injectable deps) — both live in # Orbit.Infrastructure, which is in the coverage run, so they are unit-testable and should count. + # sonar.exclusions additions — non-product / false-positive sources: + # Email/Templates/** HTML-email templates. Web:S1827/S6819/S5257 (drop cellspacing, use not role=presentation, replace layout tables with CSS) are false positives for email: table layout + cellspacing/cellpadding + role="presentation" are the required cross-client techniques (Outlook/legacy clients lack CSS layout support). Static assets with no maintainability value. + # load-tests/** k6 load-test scenario scripts — developer tooling, not shipped product code (parity with **/.claude/**). - name: SonarScanner Begin env: SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} @@ -77,7 +80,7 @@ jobs: /o:"thomasluizon" \ /d:sonar.token="${SONAR_TOKEN}" \ /d:sonar.cs.opencover.reportsPaths="**/coverage.opencover.xml" \ - /d:sonar.exclusions="**/Migrations/**,**/bin/**,**/obj/**,**/OAuth/OAuthLoginPage.cs,**/.claude/**" \ + /d:sonar.exclusions="**/Migrations/**,**/bin/**,**/obj/**,**/OAuth/OAuthLoginPage.cs,**/.claude/**,**/Email/Templates/**,**/load-tests/**" \ /d:sonar.coverage.exclusions="**/Program.cs,**/Extensions/ServiceCollectionExtensions*.cs,**/Extensions/WebApplicationExtensions.cs,**/Middleware/**,**/OpenApi/**,**/OAuth/**,**/Persistence/OrbitDbContext.cs,**/Persistence/OrbitDbContextFactory.cs,**/Persistence/GenericRepository.cs,**/Persistence/UnitOfWork.cs,**/Persistence/AccountResetRepository.cs,**/Configuration/**,**/Services/ReminderSchedulerService.cs,**/Services/SlipAlertSchedulerService.cs,**/Services/GoalDeadlineNotificationService.cs,**/Services/HabitDueDateAdvancementService.cs,**/Services/DataEncryptionMigrationService.cs,**/Services/PushNotificationService.cs,**/Services/AccountDeletionService.cs,**/Services/GoogleTokenService.cs,**/Services/BackgroundServiceHealthCheck.cs,**/Services/StripeCouponRewardService.cs,**/AI/AiCompletionClient.cs,**/Services/GeoLocationService.cs,**/Orbit.Analyzers/**" - name: Build