diff --git a/design/comments.md b/design/comments.md deleted file mode 100644 index 8d33f32643..0000000000 --- a/design/comments.md +++ /dev/null @@ -1,15 +0,0 @@ -# Design comments - -## Knowledge / Documents page - -- [ ] "Import documents" dropdown button is missing — should show a button with "+ Import documents" text and a chevron-down, with a dropdown menu containing "From your device" and "New folder" options -- [ ] "Upload document" button context — the current button exists but lacks the dropdown menu state shown in the reference - ![reference](images/comments/knowledge-import-button.png) - -## Documents page — Upload progress (#726) - -- [ ] Need a design for the upload progress state inside the document upload dialog. Currently implemented with a basic progress bar and byte counter text, but needs a proper design pass. - - Progress bar showing upload percentage (byte-level, not just per-file) - - Text showing uploaded / total bytes (e.g. "12.4 MB / 54.2 MB") - - For multi-file uploads: file completion count (e.g. "2 / 5 files completed") - - States to cover: uploading single file, uploading multiple files, upload complete diff --git a/design/images/comments/knowledge-import-button.png b/design/images/comments/knowledge-import-button.png deleted file mode 100644 index d95b4bb5a2..0000000000 Binary files a/design/images/comments/knowledge-import-button.png and /dev/null differ diff --git a/services/platform/app/components/ui/data-display/copyable-timestamp.tsx b/services/platform/app/components/ui/data-display/copyable-timestamp.tsx index df55bd3629..831f07710d 100644 --- a/services/platform/app/components/ui/data-display/copyable-timestamp.tsx +++ b/services/platform/app/components/ui/data-display/copyable-timestamp.tsx @@ -14,6 +14,8 @@ interface CopyableTimestampProps { date: number | Date | string | null | undefined; /** Format preset for display */ preset?: DatePreset; + /** Custom dayjs format string (overrides preset for display) */ + customFormat?: string; /** Additional className */ className?: string; /** Text to show when date is null/undefined */ @@ -35,6 +37,7 @@ interface CopyableTimestampProps { export const CopyableTimestamp = React.memo(function CopyableTimestamp({ date, preset = 'short', + customFormat, className, emptyText = '—', alignRight = false, @@ -63,9 +66,12 @@ export const CopyableTimestamp = React.memo(function CopyableTimestamp({ const timestampMs = String(dateObj.valueOf()); const showTimezone = preset === 'long' || preset === 'time'; - const formatted = showTimezone - ? `${formatDate(dateObj, preset)} ${timezoneShort}` + const baseFormatted = customFormat + ? formatDate(dateObj, preset, { customFormat }) : formatDate(dateObj, preset); + const formatted = showTimezone + ? `${baseFormatted} ${timezoneShort}` + : baseFormatted; const titleText = `${formatDate(dateObj, 'long')} (${timezone})`; return ( diff --git a/services/platform/app/components/ui/data-table/data-table-filters.test.tsx b/services/platform/app/components/ui/data-table/data-table-filters.test.tsx index d9d72b6f68..022890afb0 100644 --- a/services/platform/app/components/ui/data-table/data-table-filters.test.tsx +++ b/services/platform/app/components/ui/data-table/data-table-filters.test.tsx @@ -25,7 +25,7 @@ function createFilter(overrides?: Partial): FilterConfig { async function openFilterPanel( user: ReturnType, ) { - const filterButton = screen.getByRole('button', { name: /filters/i }); + const filterButton = screen.getByRole('button', { name: /filter/i }); await user.click(filterButton); } diff --git a/services/platform/app/components/ui/data-table/data-table-filters.tsx b/services/platform/app/components/ui/data-table/data-table-filters.tsx index deb1d04131..539dd4d4ff 100644 --- a/services/platform/app/components/ui/data-table/data-table-filters.tsx +++ b/services/platform/app/components/ui/data-table/data-table-filters.tsx @@ -188,7 +188,7 @@ export function DataTableFilters({ } >
- + {t('labels.filters')} {totalActiveFilters > 0 && ( diff --git a/services/platform/app/components/ui/dialog/view-dialog.stories.tsx b/services/platform/app/components/ui/dialog/view-dialog.stories.tsx index 47598c1883..1bee7513f8 100644 --- a/services/platform/app/components/ui/dialog/view-dialog.stories.tsx +++ b/services/platform/app/components/ui/dialog/view-dialog.stories.tsx @@ -111,7 +111,7 @@ export const WithHeaderActions: Story = { project-proposal.pdf 2.4 MB January 10, 2024 - January 20, 2024 + January 20, 2024 diff --git a/services/platform/app/components/ui/filters/filter-button.tsx b/services/platform/app/components/ui/filters/filter-button.tsx index 67e3ffa732..c981fb7649 100644 --- a/services/platform/app/components/ui/filters/filter-button.tsx +++ b/services/platform/app/components/ui/filters/filter-button.tsx @@ -1,4 +1,4 @@ -import { Filter } from 'lucide-react'; +import { ListFilter } from 'lucide-react'; import { Loader2Icon } from 'lucide-react'; import { ComponentProps } from 'react'; @@ -22,10 +22,9 @@ export function FilterButton({ return (