Merged
Conversation
… failed, reason: getaddrinfo ENOTFOUND alice.example
Collaborator
Author
|
Still struggling with |
Contributor
|
I struggled with this as well. Did not look at your code yet, but be aware that the order of mock calls must match the actual order of calls. That confused me a lot. A general advice would be to move all http calls as much to the edges of the library as possible (one function per fetch), use a simple straight forward fetch mock to test those functions, and then mock only those functions in the rest of the tests instead of using fetch mock |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.