fix(engine.io-client): preserve caller transport options#5501
Open
puneetdixit200 wants to merge 1 commit into
Open
fix(engine.io-client): preserve caller transport options#5501puneetdixit200 wants to merge 1 commit into
puneetdixit200 wants to merge 1 commit into
Conversation
puneetdixit200
force-pushed
the
fix/5462-preserve-transports-option
branch
from
7b19c51 to
87d7026
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5462
Tests
npm run compile --workspace=engine.io-parsernpm run compile --workspace=engine.ionpm run compile --workspace=engine.io-clientnpm run format:check --workspace=engine.io-clientnpm run test:node --workspace=engine.io-client -- --grep "caller's transports option"npm run test:node --workspace=engine.io-client -- --grep "Socket"npm run test:node --workspace=engine.io-clientgit diff --check