feat(frontend): calm OAuth Sign-in CTA for login-required servers#630
Open
Dumbris wants to merge 1 commit into
Open
feat(frontend): calm OAuth Sign-in CTA for login-required servers#630Dumbris wants to merge 1 commit into
Dumbris wants to merge 1 commit into
Conversation
Render OAuth login-required servers as an actionable amber "Sign-in"
state instead of a red "Server Error / file a bug" panel.
- utils/health.ts: oauthSignInState() + isOAuthDiagnosticCode() helpers
classify login vs. expired-session (reauth) states.
- SignInPanel.vue: new calm amber panel ("Log in") with a re-auth error
variant ("Re-login"), a docs link, and a quarantine-coexistence note.
- ServerDetail.vue: SignInPanel replaces ErrorPanel for sign-in states;
header status badge reads amber "Sign-in required".
- ServerCard.vue: matching amber "Sign-in required" status chip.
- ErrorPanel.vue: suppress the "Report a bug" / issues/new fix step for
MCPX_OAUTH_* codes (kept for genuinely unclassified faults).
- docs(oauth): document the Web UI sign-in behavior.
- Verification: vitest (16 new/extended) + Playwright sweep + report.
Related epic MCP-1819 (T2 frontend, MCP-1821).
Deploying mcpproxy-docs with
|
| Latest commit: |
2d8db54
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d4255242.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://mcp-1821-oauth-signin-cta.mcpproxy-docs.pages.dev |
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
📦 Build ArtifactsWorkflow Run: View Run Available Artifacts
How to DownloadOption 1: GitHub Web UI (easiest)
Option 2: GitHub CLI gh run download 27222084582 --repo smart-mcp-proxy/mcpproxy-go
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Render OAuth login-required upstreams as an actionable amber Sign-in CTA instead of a red "Server Error / file a bug" panel. Keys off the existing
health.action==="login"contract andMCPX_OAUTH_*diagnostic codes.Part of epic MCP-1819 (OAuth login-required = actionable Sign-in state). This is T2 (frontend) — MCP-1821. Backend hardening (T1/MCP-1820) lands the new
MCPX_OAUTH_LOGIN_REQUIREDcode in parallel; this PR keys off bothaction==="login"(already shipped) and OAuth codes, so it works before and after T1.Changes (
frontend/src)utils/health.ts—oauthSignInState()classifies a server aslogin(first-time, calm amber) vsreauth(expired/revoked session, error tone) vsnull;isOAuthDiagnosticCode()detectsMCPX_OAUTH_*.components/diagnostics/SignInPanel.vue(new) — calm amber "🔑 Sign in to {server}" with a primary Log in button (reusestriggerOAuth), a docs link, and a quarantine-coexistence note. Re-auth variant → error tone + Re-login.views/ServerDetail.vue—SignInPanelreplacesErrorPanelfor sign-in states; header status badge reads amber "Sign-in required".components/ServerCard.vue— matching amber "Sign-in required" status chip on the list.components/diagnostics/ErrorPanel.vue— suppresses the "Report a bug" /issues/newfix step forMCPX_OAUTH_*codes (kept for genuinely unclassified faults).docs/features/oauth-authentication.md— documents the Web UI sign-in behavior (ENG-9).Verification
vitest run— 138/138 pass (16 new/extended: helper classification, panel tone/label, bug-report suppression, quarantine note).vue-tsc --noEmitclean;make buildembeds the bundle.specs/oauth-signin-cta/verification/report.html.Related #MCP-1819