Fix Memory Leaks on iOS#2716
Merged
rborn merged 2 commits intoreact-native-maps:masterfrom Feb 27, 2019
Merged
Conversation
Contributor
|
These are the PR we are missing. Thank you. LGTM @rborn 🐽 |
pinpong
pushed a commit
to pinpong/react-native-maps
that referenced
this pull request
Feb 28, 2025
* Fix Memory Leaks on iOS * Fix copyright header in code files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a memory leak on iOS using Apple Maps where AIRMap didn't get deallocated if the component is unmounted during an regionChange animation.
Does any other open PR do the same thing?
No
What issue is this PR fixing?
Didn't file an issue for it and haven't found one.
How did you test this PR?
I did test it on the iPhone 8 Simulator and on a real iPhone 7 device.
Steps to reproduce:
animateToRegion- (void)mapView:(AIRMap *)mapView regionWillChangeAnimated:(__unused BOOL)animatedgets called. This method did cause the leak.- (void)mapView:(AIRMap *)mapView regionDidChangeAnimated:(__unused BOOL)animateddid get called.deallocdidn't get called in AIRMap.m