Add Marker icon property introduced in #2650 to index.d.ts#2705
Merged
christopherdro merged 1 commit intoreact-native-maps:masterfrom Mar 6, 2019
Merged
Add Marker icon property introduced in #2650 to index.d.ts#2705christopherdro merged 1 commit intoreact-native-maps:masterfrom
christopherdro merged 1 commit intoreact-native-maps:masterfrom
Conversation
…x.d.ts ### Does any other open PR do the same thing? No. ### What issue is this PR fixing? With TypeScript, trying to use the Marker's icon property results in an error, since the `index.d.ts` does not yet declare the property that was added in react-native-maps#2650. ### How did you test this PR? Tested by editing the `index.d.ts` locally. Since there are no functional changes, this is a trivial change.
pinpong
pushed a commit
to pinpong/react-native-maps
that referenced
this pull request
Feb 28, 2025
…x.d.ts (react-native-maps#2705) ### Does any other open PR do the same thing? No. ### What issue is this PR fixing? With TypeScript, trying to use the Marker's icon property results in an error, since the `index.d.ts` does not yet declare the property that was added in react-native-maps#2650. ### How did you test this PR? Tested by editing the `index.d.ts` locally. Since there are no functional changes, this is a trivial change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does any other open PR do the same thing?
No.
What issue is this PR fixing?
With TypeScript, trying to use the Marker's icon property results in an error, since the
index.d.tsdoes not yet declare the property that was added in #2650.How did you test this PR?
Tested by editing the
index.d.tslocally. Since there are no functional changes, this is a trivial change.