Skip to content

Fix type definition error#2607

Merged
rborn merged 1 commit intoreact-native-maps:masterfrom
unosk:fix-type-definition-error
Dec 3, 2018
Merged

Fix type definition error#2607
rborn merged 1 commit intoreact-native-maps:masterfrom
unosk:fix-type-definition-error

Conversation

@unosk
Copy link
Contributor

@unosk unosk commented Dec 1, 2018

Fix below errors:

  • 'setCamera', which lacks return-type annotation, implicitly has an 'any' return type.
  • 'animateCamera', which lacks return-type annotation, implicitly has an 'any' return type.

Does any other open PR do the same thing?

No

What issue is this PR fixing?

No

How did you test this PR?

Yes, I did tsc

Fix below errors:

- 'setCamera', which lacks return-type annotation, implicitly has an 'any' return type.
- 'animateCamera', which lacks return-type annotation, implicitly has an 'any' return type.
@miracle2k
Copy link

Something I missed with the PR, should be merged. @alvelig @rborn

@rborn rborn merged commit 5d17d39 into react-native-maps:master Dec 3, 2018
ryanbourneuk pushed a commit to 3sidedcube/react-native-maps that referenced this pull request Dec 10, 2018
* upstream/master: (28 commits)
  Calculate bounding box from region (react-native-maps#2615)
  [iOS GoogleMap] Fix animateCamera (react-native-maps#2608)
  Fix type definition error (react-native-maps#2607)
  [Android] Fix app crash in Android if building found but cannot getActiveLevelIndex (react-native-maps#2598)
  Provide a camera system (react-native-maps#2563)
  Get visible map bounding box (react-native-maps#2571)
  [0.22.1] Release (react-native-maps#2574)
  Move dev only deps to devDependencies. (react-native-maps#2548)
  Specify how to use Google Maps (react-native-maps#2550)
  r2507: remove marker: Attempt to invoke virtual method 'void com.google.android.gms.maps.model.setIcon(com.google.android.gms.maps.model.BitmapDescription)' on a null object reference #: remove marker: Attempt to invoke virtual method 'void com.google.android.gms.maps.model.setIcon(com.google.android.gms.maps.model.BitmapDescription)' on a null object reference (react-native-maps#2555)
  update to clarify cacheEnabled is apple maps only
  [0.22.0] Release (react-native-maps#2535)
  Fix for “The specified child already has a parent”
  Improve installation docs (react-native-maps#2541)
  fix fitToSuppliedMarkers function (react-native-maps#2524)
  Performance improvements for tracksViewChanges (react-native-maps#2487)
  fix spelling mistakes
  Added flag to make sure that there has an Observer of view.
  hotfix PR react-native-maps#2478
  Fix a peer dependencies warning
  ...
pinpong pushed a commit to pinpong/react-native-maps that referenced this pull request Feb 28, 2025
Fix below errors:

- 'setCamera', which lacks return-type annotation, implicitly has an 'any' return type.
- 'animateCamera', which lacks return-type annotation, implicitly has an 'any' return type.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants