fix: Enable button clicks on mobile coming soon page#15
Closed
sethwebster wants to merge 6 commits into
Closed
Conversation
- Fix missing ThemeSegmentedControl component (use ThemeToggle instead) - Fix button variant types in theme test pages - Use Vercel VERCEL_URL for production email links - Add 5-second polling to detect access approval in real-time - Replace purples with amber/orange complementary colors Theme system now works properly. Email links use correct production URLs. Users auto-redirect when approved (no refresh needed).
- Wrap app in ThemeProvider to fix useTheme error - Theme toggle now works in header Fixes runtime error: 'useTheme must be used within a ThemeProvider'
- Set defaultTheme='dark' in ThemeProvider - Site is designed for dark mode, not light Fixes bright white borders appearing on home page.
3D React logo canvas was capturing touch events, preventing button interactions on mobile. Added pointer-events-none to logo container and improved button responsiveness.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Code Review - PR #15SummaryThis PR addresses mobile button interaction issues and introduces a comprehensive theming system. While the core fix is solid, there are several critical concerns. Positive Aspects
Critical Issues1. Major Version Bump: Next.js 15 to 16
2. Scope Creep
3. Incomplete Implementation
Other Concerns
SecurityNo security concerns identified PerformanceMinor concerns with theme switching and hydration. Consider using next-themes library. RecommendationsCRITICAL:
HIGH:
MEDIUM:
Score: 6.5/10
Verdict: Request ChangesThe mobile fix is excellent but bundling it with massive theming refactor and Next.js 16 upgrade makes this too risky. Suggested path:
Claude Code Review - following CLAUDE.md guidelines |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pointer-events-noneto logo containerChanges
pointer-events-noneclass to ReactLogo3D container divTest Plan