Move babel-plugin-module-resolver and babel-preset-react-native to devDependencies#2548
Merged
rborn merged 1 commit intoreact-native-maps:masterfrom Nov 8, 2018
jmheik:move-to-dev-deps
Merged
Move babel-plugin-module-resolver and babel-preset-react-native to devDependencies#2548rborn merged 1 commit intoreact-native-maps:masterfrom jmheik:move-to-dev-deps
rborn merged 1 commit intoreact-native-maps:masterfrom
jmheik:move-to-dev-deps
Conversation
Contributor
Author
|
What do you think @rborn @alvelig ? This would help cleaning up quite some transitive deps from people's projects as can be seen here https://npm.anvaka.com/#/view/2d/react-native-maps |
Contributor
Contributor
|
These type of dependencies are for sure not suitable for |
Collaborator
|
@todorone done, can you add it to the 0.22.1 changelog? 🤗 |
Collaborator
|
@jmheik ❤️ |
ryanbourneuk
pushed a commit
to 3sidedcube/react-native-maps
that referenced
this pull request
Dec 10, 2018
* upstream/master: (28 commits) Calculate bounding box from region (react-native-maps#2615) [iOS GoogleMap] Fix animateCamera (react-native-maps#2608) Fix type definition error (react-native-maps#2607) [Android] Fix app crash in Android if building found but cannot getActiveLevelIndex (react-native-maps#2598) Provide a camera system (react-native-maps#2563) Get visible map bounding box (react-native-maps#2571) [0.22.1] Release (react-native-maps#2574) Move dev only deps to devDependencies. (react-native-maps#2548) Specify how to use Google Maps (react-native-maps#2550) r2507: remove marker: Attempt to invoke virtual method 'void com.google.android.gms.maps.model.setIcon(com.google.android.gms.maps.model.BitmapDescription)' on a null object reference #: remove marker: Attempt to invoke virtual method 'void com.google.android.gms.maps.model.setIcon(com.google.android.gms.maps.model.BitmapDescription)' on a null object reference (react-native-maps#2555) update to clarify cacheEnabled is apple maps only [0.22.0] Release (react-native-maps#2535) Fix for “The specified child already has a parent” Improve installation docs (react-native-maps#2541) fix fitToSuppliedMarkers function (react-native-maps#2524) Performance improvements for tracksViewChanges (react-native-maps#2487) fix spelling mistakes Added flag to make sure that there has an Observer of view. hotfix PR react-native-maps#2478 Fix a peer dependencies warning ...
pinpong
pushed a commit
to pinpong/react-native-maps
that referenced
this pull request
Feb 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does any other open PR do the same thing?
No.
What issue is this PR fixing?
Babel-plugin-module-resolver and babel-preset-react-native are included as runtime dependencies. As far as I can see they are only referred from .babelrc which is also in .npmignore, so they are not used by end users who install react-native-maps as npm module. However, these deps have quite a lot of transitive dependencies. This PR moves them to devDependencies to spare end users from downloading them and bloating the node_modules.
How did you test this PR?
I have searched the code base, and not found any other use for these two deps than .babelrc, which is excluded from npm published version.