Skip to content

Fix for “The specified child already has a parent”#2545

Merged
alvelig merged 1 commit intoreact-native-maps:masterfrom
shanereid:feature/already-has-parent-fix
Oct 12, 2018
Merged

Fix for “The specified child already has a parent”#2545
alvelig merged 1 commit intoreact-native-maps:masterfrom
shanereid:feature/already-has-parent-fix

Conversation

@shanereid
Copy link
Copy Markdown
Contributor

Does any other open PR do the same thing?

No.

What issue is this PR fixing?

I haven't created an issue for it, but seems to be the same issue found here:
#2447

Error it fixes is the following, which for me personally occurred when re-rendering with the map with a partially different set of Markers.
For performance reasons in my project on render only markers that are within the specified region are returned with render, with the map re-rendering markers using onRegionChangeComplete. With small changes it is generally fine however I found when animating a region change where a lot of markers change this crash would occur.
This simple change in the java code fixed the issue for me.
screenshot_20181011-105356_dusk

(please link the issue here)

How did you test this PR?

I only have this issue on Android, and I could consistently replicate the crash on a suite of android test devices. After the fix it was easy to confirm that it fixed the issue for me. Also the code snippet is pretty harmless and contained, checks for null and should not introduce any crashes.

@rborn
Copy link
Copy Markdown
Collaborator

rborn commented Oct 11, 2018

LGTM @alvelig 🐽

@alvelig alvelig merged commit fc3cf88 into react-native-maps:master Oct 12, 2018
@craigcoles
Copy link
Copy Markdown

Massive props @shanereid - and thanks for the speedy merge 🎉

@ShrutiGarg019
Copy link
Copy Markdown

Does any other open PR do the same thing?

No.

What issue is this PR fixing?

I haven't created an issue for it, but seems to be the same issue found here:
#2447

Error it fixes is the following, which for me personally occurred when re-rendering with the map with a partially different set of Markers.
For performance reasons in my project on render only markers that are within the specified region are returned with render, with the map re-rendering markers using onRegionChangeComplete. With small changes it is generally fine however I found when animating a region change where a lot of markers change this crash would occur.
This simple change in the java code fixed the issue for me.
screenshot_20181011-105356_dusk

(please link the issue here)

How did you test this PR?

I only have this issue on Android, and I could consistently replicate the crash on a suite of android test devices. After the fix it was easy to confirm that it fixed the issue for me. Also the code snippet is pretty harmless and contained, checks for null and should not introduce any crashes.

I am still facing same issue after this fix too.Any other solution for this??

pinpong pushed a commit to pinpong/react-native-maps that referenced this pull request Feb 28, 2025
…ady-has-parent-fix

Fix for “The specified child already has a parent”
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants