Fix for “The specified child already has a parent”#2545
Fix for “The specified child already has a parent”#2545alvelig merged 1 commit intoreact-native-maps:masterfrom
Conversation
|
LGTM @alvelig 🐽 |
|
Massive props @shanereid - and thanks for the speedy merge 🎉 |
I am still facing same issue after this fix too.Any other solution for this?? |
…ady-has-parent-fix Fix for “The specified child already has a parent”

Does any other open PR do the same thing?
No.
What issue is this PR fixing?
I haven't created an issue for it, but seems to be the same issue found here:
#2447
Error it fixes is the following, which for me personally occurred when re-rendering with the map with a partially different set of Markers.

For performance reasons in my project on render only markers that are within the specified region are returned with render, with the map re-rendering markers using
onRegionChangeComplete. With small changes it is generally fine however I found when animating a region change where a lot of markers change this crash would occur.This simple change in the java code fixed the issue for me.
(please link the issue here)
How did you test this PR?
I only have this issue on Android, and I could consistently replicate the crash on a suite of android test devices. After the fix it was easy to confirm that it fixed the issue for me. Also the code snippet is pretty harmless and contained, checks for null and should not introduce any crashes.