add edgePadding to fitToSuppliedMarkers function#2479
Merged
alvelig merged 1 commit intoreact-native-maps:masterfrom Sep 22, 2018
Merged
add edgePadding to fitToSuppliedMarkers function#2479alvelig merged 1 commit intoreact-native-maps:masterfrom
alvelig merged 1 commit intoreact-native-maps:masterfrom
Conversation
Collaborator
|
@marcelkalveram thank you ❤️ LGTM @alvelig 🐽 |
pinpong
pushed a commit
to pinpong/react-native-maps
that referenced
this pull request
Feb 28, 2025
add edgePadding to fitToSuppliedMarkers function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does any other open PR do the same thing?
No.
What issue is this PR fixing?
Adds the
edgePaddingoption to thefitToSuppliedMarkersfunction which is supported by Google Maps on both, iOS and Android. (no support for Apple Maps as the native function doesn't support this option).The feature has been requested in those two issue and I had another use case on a personal project where I had to use a workaround using
fitToCoordinates:#780
#876
Another issue is requesting it for the function
fitToElementswhich should be an easy addition if this PR gets accepted:#922
How did you test this PR?
Tested on real devices: Android Pixel and iPhone 7.
Tested on iOS simulator: iPhone 6